Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1922703004: command_buffer: Avoid glGetError after lost context (Closed)

Created:
4 years, 8 months ago by Kimmo Kinnunen
Modified:
4 years, 7 months ago
Reviewers:
zmo, Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

command_buffer: Avoid glGetError after lost context Do not call glGetError for debug info after context has been lost. BUG=581634 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/08a66a51c06a74f5ad20d16f8364254c5606b310 Cr-Commit-Position: refs/heads/master@{#390332}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 14 (5 generated)
Kimmo Kinnunen
4 years, 8 months ago (2016-04-26 10:38:45 UTC) #3
Zhenyao Mo
https://codereview.chromium.org/1922703004/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): https://codereview.chromium.org/1922703004/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc#newcode4476 gpu/command_buffer/service/gles2_cmd_decoder.cc:4476: if (DebugImpl && debug() && !WasContextLost()) { I try ...
4 years, 8 months ago (2016-04-26 17:19:39 UTC) #5
Kimmo Kinnunen
https://codereview.chromium.org/1922703004/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): https://codereview.chromium.org/1922703004/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc#newcode4476 gpu/command_buffer/service/gles2_cmd_decoder.cc:4476: if (DebugImpl && debug() && !WasContextLost()) { On 2016/04/26 ...
4 years, 8 months ago (2016-04-26 18:09:23 UTC) #6
Zhenyao Mo
On 2016/04/26 18:09:23, Kimmo Kinnunen wrote: > https://codereview.chromium.org/1922703004/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc > File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): > > https://codereview.chromium.org/1922703004/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc#newcode4476 ...
4 years, 8 months ago (2016-04-26 18:31:18 UTC) #7
Kimmo Kinnunen
On 2016/04/26 18:31:18, Zhenyao Mo wrote: > > If you have debugging on and have ...
4 years, 7 months ago (2016-04-27 06:31:59 UTC) #8
Zhenyao Mo
lgtm Thanks for the explanation.
4 years, 7 months ago (2016-04-27 16:25:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922703004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922703004/1
4 years, 7 months ago (2016-04-28 07:56:36 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 08:59:50 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:17:07 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08a66a51c06a74f5ad20d16f8364254c5606b310
Cr-Commit-Position: refs/heads/master@{#390332}

Powered by Google App Engine
This is Rietveld 408576698