Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 1922633003: Move web shell test support into a separate target. (Closed)

Created:
4 years, 8 months ago by baxley
Modified:
4 years, 8 months ago
CC:
chromium-reviews, justincohen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move web shell test support into a separate target. Test utilities should not be a part of the test case target. BUG=606815 Committed: https://crrev.com/66c47ace248ec6f45ca298d4669cff7bc61ceda3 Cr-Commit-Position: refs/heads/master@{#389833}

Patch Set 1 #

Patch Set 2 : typos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -11 lines) Patch
M ios/web/ios_web_shell_tests.gyp View 1 2 chunks +23 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
baxley
This is just a quick clean up Justin suggested to get the test helpers out ...
4 years, 8 months ago (2016-04-26 17:39:49 UTC) #2
Eugene But (OOO till 7-30)
lgtm
4 years, 8 months ago (2016-04-26 17:55:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922633003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922633003/20001
4 years, 8 months ago (2016-04-26 18:09:03 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-26 18:59:55 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 19:01:33 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/66c47ace248ec6f45ca298d4669cff7bc61ceda3
Cr-Commit-Position: refs/heads/master@{#389833}

Powered by Google App Engine
This is Rietveld 408576698