Implement TransformFeedbackManager in GPU command buffer.

gpu/command_buffer/service/context_group.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef GPU_COMMAND_BUFFER_SERVICE_CONTEXT_GROUP_H_
 #define GPU_COMMAND_BUFFER_SERVICE_CONTEXT_GROUP_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 23 matching lines @@
 class BufferManager;
 class GLES2Decoder;
 class FramebufferManager;
 class MailboxManager;
 class RenderbufferManager;
 class PathManager;
 class ProgramManager;
 class SamplerManager;
 class ShaderManager;
 class TextureManager;
+class TransformFeedbackManager;
 class MemoryTracker;
 struct DisallowedFeatures;
 
 // A Context Group helps manage multiple GLES2Decoders that share
 // resources.
 class GPU_EXPORT ContextGroup : public base::RefCounted<ContextGroup> {
  public:
   ContextGroup(
       const GpuPreferences& gpu_preferences,
       const scoped_refptr<MailboxManager>& mailbox_manager,
@@ skipping 130 matching lines @@
   }
 
   TransferBufferManager* transfer_buffer_manager() const {
     return transfer_buffer_manager_.get();
   }
 
   SamplerManager* sampler_manager() const {
     return sampler_manager_.get();
   }
 
+  TransformFeedbackManager* transform_feedback_manager() const {
+    return transform_feedback_manager_.get();
+  }
+
   uint32_t GetMemRepresented() const;
 
   // Loses all the context associated with this group.
   void LoseContexts(error::ContextLostReason reason);
 
   bool GetBufferServiceId(GLuint client_id, GLuint* service_id) const;
 
-  void AddTransformFeedbackId(GLuint client_id, GLuint service_id) {
-    transformfeedbacks_id_map_[client_id] = service_id;
-  }
-
-  bool GetTransformFeedbackServiceId(
-      GLuint client_id, GLuint* service_id) const {
-    if (client_id == 0) {
-      // Default one.
-      if (service_id)
-        *service_id = 0;
-      return true;
-    }
-    base::hash_map<GLuint, GLuint>::const_iterator iter =
-        transformfeedbacks_id_map_.find(client_id);
-    if (iter == transformfeedbacks_id_map_.end())
-      return false;
-    if (service_id)
-      *service_id = iter->second;
-    return true;
-  }
-
-  void RemoveTransformFeedbackId(GLuint client_id) {
-    transformfeedbacks_id_map_.erase(client_id);
-  }
-
   void AddSyncId(GLuint client_id, GLsync service_id) {
     syncs_id_map_[client_id] = service_id;
   }
 
   bool GetSyncServiceId(GLuint client_id, GLsync* service_id) const {
     base::hash_map<GLuint, GLsync>::const_iterator iter =
         syncs_id_map_.find(client_id);
     if (iter == syncs_id_map_.end())
       return false;
     if (service_id)
@@ skipping 56 matching lines @@
   std::unique_ptr<TextureManager> texture_manager_;
 
   std::unique_ptr<PathManager> path_manager_;
 
   std::unique_ptr<ProgramManager> program_manager_;
 
   std::unique_ptr<ShaderManager> shader_manager_;
 
   std::unique_ptr<SamplerManager> sampler_manager_;
 
+  std::unique_ptr<TransformFeedbackManager> transform_feedback_manager_;

[piman, 2016/04/28 01:38:47]

So, actually, transform feedback objects are not shared across contexts, like
query objects, vertex array objects, and... framebuffer objects (oops - this was
left undefined in GLES2, but precised in GLES3). This is clarified in the
Appendix D.

So, the transform_feedback_manager_ should be in the GLES2DecoderImpl.
(separately from this patch, we should investigate moving framebuffer_manager_
to the decoder too, but that's trickier).

[Zhenyao Mo, 2016/04/29 21:07:54]

Done.

+
   scoped_refptr<FeatureInfo> feature_info_;
 
   std::vector<base::WeakPtr<gles2::GLES2Decoder> > decoders_;
 
   // Mappings from client side IDs to service side IDs.
-  base::hash_map<GLuint, GLuint> transformfeedbacks_id_map_;
   base::hash_map<GLuint, GLsync> syncs_id_map_;
 
   DISALLOW_COPY_AND_ASSIGN(ContextGroup);
 };
 
 }  // namespace gles2
 }  // namespace gpu
 
 #endif  // GPU_COMMAND_BUFFER_SERVICE_CONTEXT_GROUP_H_