Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1922613004: jinja_template should forward "deps" to the underlying action. (Closed)

Created:
4 years, 8 months ago by slan
Modified:
4 years, 8 months ago
Reviewers:
agrieve
CC:
chromium-reviews, Simeon
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

jinja_template should forward "deps" to the underlying action. Internal Chromecast jinja_template targets need to depend on targets which generate parameters for the template. Forward "deps" to the underlying action in order to enforce these dependencies correctly. BUG= b/28381705 Committed: https://crrev.com/e83bcc73e7f0339971d97a553f7ef29d3a95c2dc Cr-Commit-Position: refs/heads/master@{#389623}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M build/config/android/rules.gni View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
slan
PTAL!
4 years, 8 months ago (2016-04-25 22:40:45 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922613004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922613004/1
4 years, 8 months ago (2016-04-25 22:41:48 UTC) #4
agrieve
On 2016/04/25 22:41:48, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 8 months ago (2016-04-25 23:55:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922613004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922613004/1
4 years, 8 months ago (2016-04-25 23:57:11 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 00:05:57 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 00:07:24 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e83bcc73e7f0339971d97a553f7ef29d3a95c2dc
Cr-Commit-Position: refs/heads/master@{#389623}

Powered by Google App Engine
This is Rietveld 408576698