Add blimp to root GN check_targets

blimp/engine/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/features.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 import("//build/config/ui.gni")
 import("//mojo/public/tools/bindings/mojom.gni")
 import("//tools/grit/repack.gni")
 import("//tools/grit/grit_rule.gni")
@@ skipping 37 matching lines @@
 source_set("app") {
   sources = [
     "app/blimp_browser_main_parts.cc",
     "app/blimp_browser_main_parts.h",
     "app/blimp_content_browser_client.cc",
     "app/blimp_content_browser_client.h",
     "app/blimp_content_main_delegate.cc",
     "app/blimp_content_main_delegate.h",
     "app/blimp_content_renderer_client.cc",
     "app/blimp_content_renderer_client.h",
-    "app/blimp_engine_config.cc",
-    "app/blimp_engine_config.h",
-    "app/blimp_network_delegate.cc",
-    "app/blimp_network_delegate.h",
-    "app/blimp_permission_manager.cc",
-    "app/blimp_permission_manager.h",
-    "app/blimp_system_url_request_context_getter.cc",
-    "app/blimp_system_url_request_context_getter.h",
-    "app/blimp_url_request_context_getter.cc",
-    "app/blimp_url_request_context_getter.h",
-    "app/engine_settings.h",
-    "app/settings_manager.cc",
-    "app/settings_manager.h",
-    "app/switches.cc",
-    "app/switches.h",
   ]
 
   deps = [
+    ":app_config",
+    ":app_net",
+    ":app_permissions",
+    ":app_settings",
+    ":app_switches",
     ":app_ui",
     ":blob_channel",
     ":common",
     ":renderer",
     ":session",
     "//base",
+    "//blimp/common:blimp_common",
     "//blimp/common/proto",
+    "//blimp/engine:blob_channel_mojo_cpp_sources",
+    "//blimp/net:blimp_net",
     "//components/web_cache/renderer",
     "//content",
     "//content/public/app:both",
     "//content/public/browser",
     "//content/public/common",
     "//content/public/renderer",
     "//content/public/utility",
+    "//net",
   ]
 }
 
+source_set("app_config") {
+  sources = [
+    "app/blimp_engine_config.cc",
+    "app/blimp_engine_config.h",
+  ]
+  deps = [
+    ":app_switches",
+    "//base",
+  ]
+}
+
+source_set("app_net") {
+  sources = [
+    "app/blimp_network_delegate.cc",
+    "app/blimp_network_delegate.h",
+    "app/blimp_system_url_request_context_getter.cc",
+    "app/blimp_system_url_request_context_getter.h",
+    "app/blimp_url_request_context_getter.cc",
+    "app/blimp_url_request_context_getter.h",
+  ]
+  deps = [
+    ":common_user_agent",
+    "//base",
+    "//content/public/browser",
+    "//net",
+  ]
+}
+
+source_set("app_permissions") {
+  sources = [
+    "app/blimp_permission_manager.cc",
+    "app/blimp_permission_manager.h",
+  ]
+  deps = [
+    "//base",
+    "//content/public/browser",
+  ]
+}
+
+source_set("app_settings") {
+  sources = [
+    "app/engine_settings.h",
+    "app/settings_manager.cc",
+    "app/settings_manager.h",
+  ]
+  deps = [
+    "//blimp/net:blimp_net",
+    "//content/public/browser",
+    "//content/public/common",
+  ]
+}
+
+source_set("app_switches") {
+  sources = [
+    "app/switches.cc",
+    "app/switches.h",
+  ]
+}
+
 source_set("app_ui") {
   sources = [
     "app/ui/blimp_layout_manager.cc",
     "app/ui/blimp_layout_manager.h",
     "app/ui/blimp_screen.cc",
     "app/ui/blimp_screen.h",
     "app/ui/blimp_window_tree_client.cc",
     "app/ui/blimp_window_tree_client.h",
     "app/ui/blimp_window_tree_host.cc",
     "app/ui/blimp_window_tree_host.h",
@@ skipping 15 matching lines @@
 
 source_set("common") {
   sources = [
     "common/blimp_browser_context.cc",
     "common/blimp_browser_context.h",
     "common/blimp_content_client.cc",
     "common/blimp_content_client.h",
   ]
 
   deps = [
+    ":app_net",
+    ":app_permissions",
+    ":common_user_agent",
     "//base",
+    "//content/public/browser",
+    "//content/public/common",
+    "//net",
+    "//ui/base",
+  ]
+}
+
+source_set("common_user_agent") {
+  sources = [
+    "common/blimp_user_agent.cc",
+    "common/blimp_user_agent.h",
+  ]
+  deps = [
     "//components/version_info",
     "//content/public/common",
-    "//ui/base",
   ]
 }
 
 source_set("feature") {
   sources = [
     "feature/engine_render_widget_feature.cc",
     "feature/engine_render_widget_feature.h",
     "feature/engine_settings_feature.cc",
     "feature/engine_settings_feature.h",
   ]
 
   deps = [
     "//base",
+    "//blimp/common:blimp_common",
     "//blimp/common/proto",
+    "//blimp/engine:app_settings",
+    "//blimp/engine:common",
+    "//blimp/net:blimp_net",
+    "//content/public/browser",
+    "//content/public/common",
+    "//net",
     "//ui/base",
     "//ui/base/ime",
     "//ui/resources",
     "//ui/wm",
   ]
 }
 
 source_set("renderer") {
   sources = [
     "renderer/engine_image_serialization_processor.cc",
     "renderer/engine_image_serialization_processor.h",
   ]
 
   deps = [
     ":blob_channel_mojo",
     "//base",
     "//blimp/common:blimp_common",
     "//blimp/common/proto",
     "//cc",
+    "//content/public/renderer",
     "//skia",
     "//third_party/libwebp",
     "//ui/gfx/geometry",
     "//ui/gl",
   ]
 }
 
 source_set("session") {
   sources = [
     "session/blimp_engine_session.cc",
     "session/blimp_engine_session.h",
   ]
 
   deps = [
+    ":app_config",
+    ":app_settings",
+    ":app_switches",
+    ":app_ui",
+    ":common",
     ":feature",
     "//base",
     "//blimp/common:blimp_common",
     "//blimp/common/proto",
     "//blimp/net:blimp_net",
     "//content",
     "//net",
+    "//ui/aura",
+    "//ui/base/ime",
+    "//ui/wm",
   ]
 }
 
 # Implements the browser portions of the Mojo bridge to BlobChannel.
 source_set("blob_channel") {
   sources = [
     "mojo/blob_channel_service.cc",
     "mojo/blob_channel_service.h",
   ]
   deps = [
@@ skipping 11 matching lines @@
   testonly = true
 
   sources = [
     "app/blimp_engine_config_unittest.cc",
     "app/settings_manager_unittest.cc",
     "app/ui/blimp_screen_unittest.cc",
   ]
 
   deps = [
     ":app",
+    ":app_config",
+    ":app_settings",
+    ":app_switches",
     "//base",
     "//base/test:run_all_unittests",
     "//base/test:test_support",
+    "//blimp/engine:app_ui",
     "//testing/gmock",
     "//testing/gtest",
     "//ui/gfx:test_support",
   ]
 }
 
 source_set("feature_unit_tests") {
   testonly = true
 
   sources = [
     "feature/engine_render_widget_feature_unittest.cc",
     "feature/engine_settings_feature_unittest.cc",
   ]
 
   deps = [
     ":feature",
     "//base",
     "//base/test:run_all_unittests",
     "//base/test:test_support",
+    "//blimp/common:blimp_common",
     "//blimp/common/proto",
+    "//blimp/engine:app_settings",
+    "//blimp/net:blimp_net",
+    "//blimp/net:test_support",
     "//content",
+    "//net",
+    "//net:test_support",
     "//testing/gmock",
     "//testing/gtest",
+    "//ui/base/ime",
   ]
 }
 
 source_set("unit_tests") {
   testonly = true
 
   deps = [
     ":app_unit_tests",
     ":feature_unit_tests",
   ]
 }
 
 if (is_linux) {
   executable("blimp_engine_app") {
     sources = [
       "app/blimp_main.cc",
     ]
 
     deps = [
       ":app",
       ":pak",
+      "//base",
       "//blimp/net:blimp_net",
-      "//content/public/app:both",
+      "//content",

[Dirk Pranke, 2016/04/26 01:21:44]

Actually, thinking about this now, I might've gotten the direction backwards,
and you should actually unconditionally depend on //content/public/app:both ,
and we should modify that to forward the right configs in the component_build
case.

But, I can't remember for sure. jam@, brettw@, which way is right here?

[brettw, 2016/04/26 04:59:40]

I think there is some context that I'm missing. But depending directly on
content is pretty suspicious and without context, app:both looks more correct.

[nyquist, 2016/04/26 21:47:50]

Updated https://codereview.chromium.org/1914933004/ with this change, and
updated all places in //blimp to never depend on //content, but instead always
depend on more specific targets within //content/public.

     ]
   }
 
   group("blimp_engine") {
     deps = [
       ":blimp_engine_app",
       ":pak",
       "//sandbox/linux:chrome_sandbox",
       "//third_party/blimp_fonts",
     ]
@@ skipping 36 matching lines @@
       _rebased_dockerfile,
       "--startup-script",
       _rebased_startup_script,
       "--manifest",
       _rebased_manifest,
       "--output",
       rebase_path(_bundle),
     ]
   }
 }