Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1922603006: [JSON] implement indentation in the BasicJsonStringifier and expose via API. (Closed)

Created:
4 years, 8 months ago by Yang
Modified:
4 years, 7 months ago
CC:
kozy, Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[JSON] implement indentation in the BasicJsonStringifier and expose via API. R=jochen@chromium.org, verwaest@chromium.org Committed: https://crrev.com/e17c68c49355ca83cddec2d050ac8d95005762c5 Cr-Commit-Position: refs/heads/master@{#36392}

Patch Set 1 #

Patch Set 2 : fix test case #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -38 lines) Patch
M include/v8.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/api.cc View 1 2 1 chunk +7 lines, -2 lines 0 comments Download
M src/js/json.js View 3 chunks +8 lines, -5 lines 0 comments Download
M src/json-stringifier.h View 15 chunks +55 lines, -14 lines 0 comments Download
M src/runtime/runtime.h View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M src/runtime/runtime-json.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M src/string-builder.h View 1 chunk +8 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M test/mjsunit/es6/proxies-json.js View 2 chunks +5 lines, -1 line 0 comments Download
M test/mjsunit/es6/symbols.js View 1 chunk +3 lines, -1 line 0 comments Download
M test/mjsunit/harmony/simd.js View 1 chunk +3 lines, -1 line 0 comments Download
M test/mjsunit/json.js View 2 chunks +5 lines, -3 lines 0 comments Download
M test/mjsunit/json2.js View 1 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Yang
4 years, 8 months ago (2016-04-26 12:30:36 UTC) #1
Yang
Please take a look. The API is required by Devtools.
4 years, 8 months ago (2016-04-26 12:32:10 UTC) #2
Toon Verwaest
lgtm
4 years, 8 months ago (2016-04-27 09:39:25 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-27 09:41:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922603006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922603006/1
4 years, 8 months ago (2016-04-27 09:45:20 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/785) v8_linux64_avx2_rel_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 8 months ago (2016-04-27 10:02:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922603006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922603006/40001
4 years, 7 months ago (2016-05-20 07:24:09 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-20 07:56:59 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 07:58:12 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/e17c68c49355ca83cddec2d050ac8d95005762c5
Cr-Commit-Position: refs/heads/master@{#36392}

Powered by Google App Engine
This is Rietveld 408576698