Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6464)

Unified Diff: chrome/test/BUILD.gn

Issue 1922563002: Created BUILD.gn for libsecret (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed gn dep for unittests Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/BUILD.gn
diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn
index ba6681295d1e9eef16eb29d1c544f80a128567a4..ff526bd2269859eead976639a33e346600fa43e9 100644
--- a/chrome/test/BUILD.gn
+++ b/chrome/test/BUILD.gn
@@ -1410,6 +1410,7 @@ if (!is_android) {
"//testing/gmock",
"//testing/gtest",
"//third_party/WebKit/public:blink",
+
# Language detection is irrelevant to sync, so it can depend on any
# implementation for CLD2. Dynamic is smaller, so go with dynamic.
"//third_party/cld_2:cld2_dynamic",
@@ -1484,6 +1485,7 @@ if (!is_android) {
"//sync",
"//testing/gmock",
"//testing/gtest",
+
# Language detection is irrelevant to sync, so it can depend on any
# implementation for CLD2. Dynamic is smaller, so go with dynamic.
"//third_party/cld_2:cld2_dynamic",
@@ -1635,6 +1637,7 @@ test("unit_tests") {
"//google_apis",
"//skia",
"//third_party/cacheinvalidation",
+
# Unit tests should be independent of the CLD2 access mechanism, just use
# static for simplicity.
"//third_party/cld_2:cld2_static",
@@ -1958,6 +1961,7 @@ test("unit_tests") {
if (is_linux && !is_chromeos) {
sources +=
[ "../browser/password_manager/native_backend_libsecret_unittest.cc" ]
+ deps += [ "//third_party/libsecret" ]
}
if (is_linux && use_aura) {
deps += [
@@ -2212,7 +2216,7 @@ if (is_win || (is_linux && !is_chromeos)) {
"//testing/gmock",
"//testing/gtest",
"//testing/perf",
- "//third_party/cld_2:cld2_platform_impl"
+ "//third_party/cld_2:cld2_platform_impl",
]
if (is_win) {

Powered by Google App Engine
This is Rietveld 408576698