Created BUILD.gn for libsecret

third_party/libsecret/BUILD.gn

Index: third_party/libsecret/BUILD.gn
diff --git a/third_party/libsecret/BUILD.gn b/third_party/libsecret/BUILD.gn
new file mode 100644
index 0000000000000000000000000000000000000000..e9f192bbf4de454c1b879bf152244d02d952bcbf
--- /dev/null
+++ b/third_party/libsecret/BUILD.gn
@@ -0,0 +1,11 @@
+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file
+
+config("libsecret_as_system") {

[vabr (Chromium), 2016/04/27 11:14:24]

nit: The "as_system" could be confusing. I guess it relates to using <> in the
#include? I'm not sure we need to mention this in the config name. The name can
be something generic, like "libsecret_config", because it is clear from the body
itself what it does.

[cfroussios, 2016/04/27 12:44:02]

Done.

+  include_dirs = [ rebase_path("./") ]
+}
+
+component("libsecret") {

[vabr (Chromium), 2016/04/27 11:14:24]

This could be a source_set. A component is a shared_library in component build,
and that does not make sense for a collection of headers. A source_set is simply
a set of sources. If there were any .cc files, those would get compiled, but not
linked into a library, but that's not applicable here anyway. For headers, there
is no action.

[cfroussios, 2016/04/27 12:44:02]

Done.

+  public_configs = [ ":libsecret_as_system" ]

[vabr (Chromium), 2016/04/27 11:14:24]

Please also add the "sources" field and list all the headers, to capture the
dependency (otherwise changes to the headers won't result in recompilation, and
missing headers will be reported by the compiler instead of earlier by GN).

[cfroussios, 2016/04/27 12:44:02]

Done.

+}