third_party/libsecret/BUILD.gn - Issue 1922563002: Created BUILD.gn for libsecret

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/libsecret/BUILD.gn

Issue 1922563002: Created BUILD.gn for libsecret (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Using include_dirs instead of cflags to build Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file

	4

	5 config("libsecret_as_system") {
	vabr (Chromium) 2016/04/27 11:14:24 nit: The "as_system" could be confusing. I guess i nit: The "as_system" could be confusing. I guess it relates to using <> in the #include? I'm not sure we need to mention this in the config name. The name can be something generic, like "libsecret_config", because it is clear from the body itself what it does. cfroussios 2016/04/27 12:44:02 Done. Show quoted text On 2016/04/27 11:14:24, vabr (Chromium) wrote: > nit: The "as_system" could be confusing. I guess it relates to using <> in the > #include? I'm not sure we need to mention this in the config name. The name can > be something generic, like "libsecret_config", because it is clear from the body > itself what it does. Done.
	6 include_dirs = [ rebase_path("./") ]

	7 }

	8

	9 component("libsecret") {
	vabr (Chromium) 2016/04/27 11:14:24 This could be a source_set. A component is a share This could be a source_set. A component is a shared_library in component build, and that does not make sense for a collection of headers. A source_set is simply a set of sources. If there were any .cc files, those would get compiled, but not linked into a library, but that's not applicable here anyway. For headers, there is no action. cfroussios 2016/04/27 12:44:02 Done. Show quoted text On 2016/04/27 11:14:24, vabr (Chromium) wrote: > This could be a source_set. A component is a shared_library in component build, > and that does not make sense for a collection of headers. A source_set is simply > a set of sources. If there were any .cc files, those would get compiled, but not > linked into a library, but that's not applicable here anyway. For headers, there > is no action. Done.
	10 public_configs = [ ":libsecret_as_system" ]
	vabr (Chromium) 2016/04/27 11:14:24 Please also add the "sources" field and list all t Please also add the "sources" field and list all the headers, to capture the dependency (otherwise changes to the headers won't result in recompilation, and missing headers will be reported by the compiler instead of earlier by GN). cfroussios 2016/04/27 12:44:02 Done. Show quoted text On 2016/04/27 11:14:24, vabr (Chromium) wrote: > Please also add the "sources" field and list all the headers, to capture the > dependency (otherwise changes to the headers won't result in recompilation, and > missing headers will be reported by the compiler instead of earlier by GN). Done.
	11 }

OLD	NEW

« chrome/chrome_tests_unit.gypi ('K') | « chrome/test/BUILD.gn ('k') | third_party/libsecret/libsecret/secret.h » ('j') | no next file with comments »