Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: src/crankshaft/arm64/lithium-codegen-arm64.cc

Issue 1922553002: Get rid of AllocationFlags::TAG_OBJECT (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove TAG_OBJECT from AllocationFlags Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/arm/lithium-codegen-arm.cc ('k') | src/crankshaft/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/arm64/lithium-codegen-arm64.h" 5 #include "src/crankshaft/arm64/lithium-codegen-arm64.h"
6 6
7 #include "src/arm64/frames-arm64.h" 7 #include "src/arm64/frames-arm64.h"
8 #include "src/base/bits.h" 8 #include "src/base/bits.h"
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1398 matching lines...) Expand 10 before | Expand all | Expand 10 after
1409 LAllocate* instr_; 1409 LAllocate* instr_;
1410 }; 1410 };
1411 1411
1412 DeferredAllocate* deferred = new(zone()) DeferredAllocate(this, instr); 1412 DeferredAllocate* deferred = new(zone()) DeferredAllocate(this, instr);
1413 1413
1414 Register result = ToRegister(instr->result()); 1414 Register result = ToRegister(instr->result());
1415 Register temp1 = ToRegister(instr->temp1()); 1415 Register temp1 = ToRegister(instr->temp1());
1416 Register temp2 = ToRegister(instr->temp2()); 1416 Register temp2 = ToRegister(instr->temp2());
1417 1417
1418 // Allocate memory for the object. 1418 // Allocate memory for the object.
1419 AllocationFlags flags = TAG_OBJECT; 1419 AllocationFlags flags = NO_ALLOCATION_FLAGS;
1420 if (instr->hydrogen()->MustAllocateDoubleAligned()) { 1420 if (instr->hydrogen()->MustAllocateDoubleAligned()) {
1421 flags = static_cast<AllocationFlags>(flags | DOUBLE_ALIGNMENT); 1421 flags = static_cast<AllocationFlags>(flags | DOUBLE_ALIGNMENT);
1422 } 1422 }
1423 1423
1424 if (instr->hydrogen()->IsOldSpaceAllocation()) { 1424 if (instr->hydrogen()->IsOldSpaceAllocation()) {
1425 DCHECK(!instr->hydrogen()->IsNewSpaceAllocation()); 1425 DCHECK(!instr->hydrogen()->IsNewSpaceAllocation());
1426 flags = static_cast<AllocationFlags>(flags | PRETENURE); 1426 flags = static_cast<AllocationFlags>(flags | PRETENURE);
1427 } 1427 }
1428 1428
1429 if (instr->size()->IsConstantOperand()) { 1429 if (instr->size()->IsConstantOperand()) {
(...skipping 4295 matching lines...) Expand 10 before | Expand all | Expand 10 after
5725 // Index is equal to negated out of object property index plus 1. 5725 // Index is equal to negated out of object property index plus 1.
5726 __ Sub(result, result, Operand::UntagSmiAndScale(index, kPointerSizeLog2)); 5726 __ Sub(result, result, Operand::UntagSmiAndScale(index, kPointerSizeLog2));
5727 __ Ldr(result, FieldMemOperand(result, 5727 __ Ldr(result, FieldMemOperand(result,
5728 FixedArray::kHeaderSize - kPointerSize)); 5728 FixedArray::kHeaderSize - kPointerSize));
5729 __ Bind(deferred->exit()); 5729 __ Bind(deferred->exit());
5730 __ Bind(&done); 5730 __ Bind(&done);
5731 } 5731 }
5732 5732
5733 } // namespace internal 5733 } // namespace internal
5734 } // namespace v8 5734 } // namespace v8
OLDNEW
« no previous file with comments | « src/crankshaft/arm/lithium-codegen-arm.cc ('k') | src/crankshaft/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698