Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 1922553002: Get rid of AllocationFlags::TAG_OBJECT (Closed)

Created:
4 years, 7 months ago by Michael Lippautz
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Get rid of AllocationFlags::TAG_OBJECT Default (and only way) is now to retrieve a tagged object. BUG=chromium:606711 LOG=N Committed: https://crrev.com/ef49c6b11a7a382909c2fbe1c5f38a8c3e1e4fb8 Cr-Commit-Position: refs/heads/master@{#35792}

Patch Set 1 #

Patch Set 2 : ia32 #

Patch Set 3 : arm #

Patch Set 4 : arm fixed #

Patch Set 5 : initial arm64 #

Patch Set 6 : arm64 improved #

Patch Set 7 : mips #

Patch Set 8 : mips64 #

Patch Set 9 : x87 #

Patch Set 10 : Remove TAG_OBJECT from AllocationFlags #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -504 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 8 chunks +11 lines, -19 lines 0 comments Download
M src/arm/codegen-arm.cc View 1 2 3 2 chunks +6 lines, -3 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 2 11 chunks +17 lines, -37 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 3 4 5 8 chunks +11 lines, -18 lines 0 comments Download
M src/arm64/codegen-arm64.cc View 1 2 3 4 5 5 chunks +12 lines, -13 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 2 3 4 10 chunks +19 lines, -34 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 2 5 chunks +5 lines, -12 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 2 3 4 5 6 5 chunks +5 lines, -12 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 2 3 4 5 6 7 4 chunks +4 lines, -8 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 2 3 4 2 chunks +4 lines, -2 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 2 3 4 5 6 2 chunks +4 lines, -2 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 2 3 4 5 6 7 2 chunks +4 lines, -2 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 8 chunks +11 lines, -19 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 12 chunks +24 lines, -47 lines 0 comments Download
M src/macro-assembler.h View 1 2 3 4 5 6 7 8 9 1 chunk +4 lines, -7 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 2 3 4 5 6 8 chunks +13 lines, -19 lines 0 comments Download
M src/mips/codegen-mips.cc View 1 2 3 4 5 6 6 chunks +12 lines, -10 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 2 3 4 5 6 11 chunks +17 lines, -37 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 2 3 4 5 6 7 8 chunks +13 lines, -19 lines 0 comments Download
M src/mips64/codegen-mips64.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 2 3 4 5 6 7 11 chunks +17 lines, -37 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 8 chunks +11 lines, -19 lines 0 comments Download
M src/x64/codegen-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 10 chunks +18 lines, -39 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 2 3 4 5 6 7 8 8 chunks +11 lines, -19 lines 0 comments Download
M src/x87/codegen-x87.cc View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -4 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 2 3 4 5 6 7 8 12 chunks +22 lines, -46 lines 0 comments Download

Messages

Total messages: 24 (14 generated)
Michael Lippautz
Benedikt: ptal Hannes: fyi The idea is to (1) only allocate tagged objects (this CL) ...
4 years, 7 months ago (2016-04-25 17:52:37 UTC) #5
Benedikt Meurer
Awesome, thanks for doing this cleanup. LGTM!
4 years, 7 months ago (2016-04-25 17:57:15 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922553002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922553002/240001
4 years, 7 months ago (2016-04-26 09:00:10 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922553002/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922553002/260001
4 years, 7 months ago (2016-04-26 09:17:43 UTC) #13
Michael Lippautz
All ports done, ptal.
4 years, 7 months ago (2016-04-26 09:32:15 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-26 09:40:54 UTC) #17
Benedikt Meurer
Still awesome! Still LGTM :-)
4 years, 7 months ago (2016-04-26 10:30:40 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922553002/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922553002/260001
4 years, 7 months ago (2016-04-26 12:00:31 UTC) #20
commit-bot: I haz the power
Committed patchset #10 (id:260001)
4 years, 7 months ago (2016-04-26 12:02:56 UTC) #22
commit-bot: I haz the power
4 years, 7 months ago (2016-04-26 12:04:12 UTC) #24
Message was sent while issue was closed.
Patchset 10 (id:??) landed as
https://crrev.com/ef49c6b11a7a382909c2fbe1c5f38a8c3e1e4fb8
Cr-Commit-Position: refs/heads/master@{#35792}

Powered by Google App Engine
This is Rietveld 408576698