Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 192253002: Rename SigninManagerDelegate to SigninClient (Closed)

Created:
6 years, 9 months ago by blundell
Modified:
6 years, 9 months ago
Reviewers:
Jói
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Rename SigninManagerDelegate to SigninClient This renaming puts the Signin embedder interface in line with the agreed-upon convention wherein a component Foo's embedder interface should be named FooClient. ChromeSigninManagerDelegate is similarly renamed to ChromeSigninClient, and variable names are updated. BUG=334168 TBR=joi Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255903

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -148 lines) Patch
A + chrome/browser/signin/chrome_signin_client.h View 2 chunks +9 lines, -9 lines 0 comments Download
A + chrome/browser/signin/chrome_signin_client.cc View 2 chunks +8 lines, -12 lines 0 comments Download
D chrome/browser/signin/chrome_signin_manager_delegate.h View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/browser/signin/chrome_signin_manager_delegate.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M chrome/browser/signin/fake_signin_manager.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/signin/signin_manager.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/signin/signin_manager.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/signin/signin_manager_factory.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/signin/signin_manager_unittest.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M components/signin.gypi View 1 chunk +1 line, -1 line 0 comments Download
A + components/signin/core/signin_client.h View 1 chunk +7 lines, -7 lines 0 comments Download
D components/signin/core/signin_manager_delegate.h View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
blundell
TBR'ing as we discussed for changes of this kind. Thanks!
6 years, 9 months ago (2014-03-09 17:14:34 UTC) #1
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 9 months ago (2014-03-09 17:14:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/192253002/1
6 years, 9 months ago (2014-03-09 17:14:59 UTC) #3
commit-bot: I haz the power
Change committed as 255903
6 years, 9 months ago (2014-03-10 07:25:51 UTC) #4
Jói
6 years, 9 months ago (2014-03-10 14:42:29 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698