Revert of CrossThreadPersistentRegion will only trace objects

Revert of CrossThreadPersistentRegion will only trace objects belonging to the current GCing ThreadHeap (patchset #2 id:20001 of https://codereview.chromium.org/1904003002/ )

Reason for revert:
Reverting in order to revert r 389052

Original issue's description:
> CrossThreadPersistentRegion will only trace objects belonging to the current GCing ThreadHeap
>
> CrossThreadPersistentRegion will be globally shared so we need to limit the tracing to objects belonging to the current GCing ThreadHeap.
>
> BUG=591606
>
> Committed: https://crrev.com/8cc8d1cd549bcb95653e501f6f2a4b77170d1d1a
> Cr-Commit-Position: refs/heads/master@{#389433}

TBR=oilpan-reviews@chromium.org,haraken@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=591606
Committed: https://crrev.com/5fbae6f24d9399952ed8f056b35d3a78ee7d6e75
Cr-Commit-Position: refs/heads/master@{#389469}

[keishi, 2016-04-25 12:10:19]

Created Revert of CrossThreadPersistentRegion will only trace objects belonging
to the current GCing ThreadHeap

[commit-bot: I haz the power, 2016-04-25 12:11:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-25 12:11:44]

The CQ bit was unchecked by commit-bot@chromium.org

[keishi, 2016-04-25 12:17:58]

The CQ bit was checked by keishi@chromium.org

[commit-bot: I haz the power, 2016-04-25 12:18:32]

The CQ bit was unchecked by commit-bot@chromium.org

[haraken, 2016-04-25 12:22:04]

LGTM

[keishi, 2016-04-25 12:46:24]

The CQ bit was checked by keishi@chromium.org

[commit-bot: I haz the power, 2016-04-25 12:46:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1922493002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1922493002/1

[commit-bot: I haz the power, 2016-04-25 12:46:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-25 12:46:52]

Failed to apply patch for
third_party/WebKit/Source/platform/heap/PersistentNode.cpp:
While running git apply --index -3 -p1;
  error: patch failed:
third_party/WebKit/Source/platform/heap/PersistentNode.cpp:102
  Falling back to three-way merge...
  Applied patch to 'third_party/WebKit/Source/platform/heap/PersistentNode.cpp'
with conflicts.
  U third_party/WebKit/Source/platform/heap/PersistentNode.cpp

Patch:       third_party/WebKit/Source/platform/heap/PersistentNode.cpp
Index: third_party/WebKit/Source/platform/heap/PersistentNode.cpp
diff --git a/third_party/WebKit/Source/platform/heap/PersistentNode.cpp
b/third_party/WebKit/Source/platform/heap/PersistentNode.cpp
index
233fbc348b44764092038b2208cfbaa4e7b64927..329a0370df7d9394b8dc5fbec439def948f2ae43
100644
--- a/third_party/WebKit/Source/platform/heap/PersistentNode.cpp
+++ b/third_party/WebKit/Source/platform/heap/PersistentNode.cpp
@@ -49,7 +49,7 @@
 // a PersistentNodeSlot that contains only freed PersistentNodes,
 // we delete the PersistentNodeSlot. This function rebuilds the free
 // list of PersistentNodes.
-void PersistentRegion::tracePersistentNodes(Visitor* visitor,
ShouldTraceCallback shouldTrace)
+void PersistentRegion::tracePersistentNodes(Visitor* visitor)
 {
     size_t debugMarkedObjectSize = ProcessHeap::totalMarkedObjectSize();
     base::debug::Alias(&debugMarkedObjectSize);
@@ -71,10 +71,8 @@
                 freeListNext = node;
                 ++freeCount;
             } else {
+                node->tracePersistentNode(visitor);
                 ++persistentCount;
-                if (!shouldTrace(visitor, node))
-                    continue;
-                node->tracePersistentNode(visitor);
                 debugMarkedObjectSize = ProcessHeap::totalMarkedObjectSize();
             }
         }
@@ -102,16 +100,6 @@
 public:
     DEFINE_INLINE_TRACE() { }
 };
-}
-
-bool CrossThreadPersistentRegion::shouldTracePersistentNode(Visitor* visitor,
PersistentNode* node)
-{
-    CrossThreadPersistent<GCObject>* persistent =
reinterpret_cast<CrossThreadPersistent<GCObject>*>(node->self());
-    ASSERT(persistent);
-    Address rawObject = reinterpret_cast<Address>(persistent->get());
-    if (!rawObject)
-        return false;
-    return &visitor->heap() == &ThreadState::fromObject(rawObject)->heap();
 }
 
 void CrossThreadPersistentRegion::prepareForThreadStateTermination(ThreadState*
threadState)

[keishi, 2016-04-25 14:05:41]

The CQ bit was checked by keishi@chromium.org

[keishi, 2016-04-25 14:05:41]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1922493002/#ps100001
(title: "rebased")

[commit-bot: I haz the power, 2016-04-25 14:05:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1922493002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1922493002/100001

[commit-bot: I haz the power, 2016-04-25 14:06:29]

Committed patchset #2 (id:100001)

[commit-bot: I haz the power, 2016-04-25 14:07:44]

Description was changed from

==========
Revert of CrossThreadPersistentRegion will only trace objects belonging to the
current GCing ThreadHeap (patchset #2 id:20001 of
https://codereview.chromium.org/1904003002/ )

Reason for revert:
Reverting in order to revert r 389052

Original issue's description:
> CrossThreadPersistentRegion will only trace objects belonging to the current
GCing ThreadHeap
> 
> CrossThreadPersistentRegion will be globally shared so we need to limit the
tracing to objects belonging to the current GCing ThreadHeap.
> 
> BUG=591606
> 
> Committed: https://crrev.com/8cc8d1cd549bcb95653e501f6f2a4b77170d1d1a
> Cr-Commit-Position: refs/heads/master@{#389433}

TBR=oilpan-reviews@chromium.org,haraken@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=591606
==========

to

==========
Revert of CrossThreadPersistentRegion will only trace objects belonging to the
current GCing ThreadHeap (patchset #2 id:20001 of
https://codereview.chromium.org/1904003002/ )

Reason for revert:
Reverting in order to revert r 389052

Original issue's description:
> CrossThreadPersistentRegion will only trace objects belonging to the current
GCing ThreadHeap
>
> CrossThreadPersistentRegion will be globally shared so we need to limit the
tracing to objects belonging to the current GCing ThreadHeap.
>
> BUG=591606
>
> Committed: https://crrev.com/8cc8d1cd549bcb95653e501f6f2a4b77170d1d1a
> Cr-Commit-Position: refs/heads/master@{#389433}

TBR=oilpan-reviews@chromium.org,haraken@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=591606

Committed: https://crrev.com/5fbae6f24d9399952ed8f056b35d3a78ee7d6e75
Cr-Commit-Position: refs/heads/master@{#389469}
==========

[commit-bot: I haz the power, 2016-04-25 14:07:45]

Patchset 2 (id:??) landed as
https://crrev.com/5fbae6f24d9399952ed8f056b35d3a78ee7d6e75
Cr-Commit-Position: refs/heads/master@{#389469}