Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Unified Diff: chrome/app/chrome_crash_reporter_client_win.h

Issue 1922473003: Scrub the vestigal breakpad crash dump attempts metrics code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove the installer's override of a removed method. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/app/chrome_crash_reporter_client_win.h
diff --git a/chrome/app/chrome_crash_reporter_client_win.h b/chrome/app/chrome_crash_reporter_client_win.h
index 7fcec6df364b837d99126b47d73972dc8c20358b..bcf7f7974ce455448fdca737c386c905b648d293 100644
--- a/chrome/app/chrome_crash_reporter_client_win.h
+++ b/chrome/app/chrome_crash_reporter_client_win.h
@@ -13,10 +13,6 @@
#include "build/build_config.h"
#include "components/crash/content/app/crash_reporter_client.h"
-namespace browser_watcher {
-class CrashReportingMetrics;
-} // namespace browser_watcher
-
class ChromeCrashReporterClient : public crash_reporter::CrashReporterClient {
public:
ChromeCrashReporterClient();
@@ -37,7 +33,6 @@ class ChromeCrashReporterClient : public crash_reporter::CrashReporterClient {
bool GetIsPerUserInstall(const base::FilePath& exe_path) override;
bool GetShouldDumpLargerDumps(bool is_per_user_install) override;
int GetResultCodeRespawnFailed() override;
- void InitBrowserCrashDumpsRegKey() override;
void RecordCrashDumpAttempt(bool is_real_crash) override;
void RecordCrashDumpAttemptResult(bool is_real_crash,
bool succeeded) override;
@@ -55,9 +50,6 @@ class ChromeCrashReporterClient : public crash_reporter::CrashReporterClient {
bool EnableBreakpadForProcess(const std::string& process_type) override;
private:
- std::unique_ptr<browser_watcher::CrashReportingMetrics>
- crash_reporting_metrics_;
-
DISALLOW_COPY_AND_ASSIGN(ChromeCrashReporterClient);
};

Powered by Google App Engine
This is Rietveld 408576698