Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: chrome/app/chrome_crash_reporter_client_win.h

Issue 1922473003: Scrub the vestigal breakpad crash dump attempts metrics code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Greg's comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/app/chrome_crash_reporter_client_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_APP_CHROME_CRASH_REPORTER_CLIENT_WIN_H_ 5 #ifndef CHROME_APP_CHROME_CRASH_REPORTER_CLIENT_WIN_H_
6 #define CHROME_APP_CHROME_CRASH_REPORTER_CLIENT_WIN_H_ 6 #define CHROME_APP_CHROME_CRASH_REPORTER_CLIENT_WIN_H_
7 7
8 #include <stddef.h>
9 #include <memory>
10
11 #include "base/compiler_specific.h"
12 #include "base/macros.h" 8 #include "base/macros.h"
13 #include "build/build_config.h"
14 #include "components/crash/content/app/crash_reporter_client.h" 9 #include "components/crash/content/app/crash_reporter_client.h"
15 10
16 namespace browser_watcher {
17 class CrashReportingMetrics;
18 } // namespace browser_watcher
19
20 class ChromeCrashReporterClient : public crash_reporter::CrashReporterClient { 11 class ChromeCrashReporterClient : public crash_reporter::CrashReporterClient {
21 public: 12 public:
22 ChromeCrashReporterClient(); 13 ChromeCrashReporterClient();
23 ~ChromeCrashReporterClient() override; 14 ~ChromeCrashReporterClient() override;
24 15
25 // crash_reporter::CrashReporterClient implementation. 16 // crash_reporter::CrashReporterClient implementation.
26 bool GetAlternativeCrashDumpLocation(base::FilePath* crash_dir) override; 17 bool GetAlternativeCrashDumpLocation(base::FilePath* crash_dir) override;
27 void GetProductNameAndVersion(const base::FilePath& exe_path, 18 void GetProductNameAndVersion(const base::FilePath& exe_path,
28 base::string16* product_name, 19 base::string16* product_name,
29 base::string16* version, 20 base::string16* version,
30 base::string16* special_build, 21 base::string16* special_build,
31 base::string16* channel_name) override; 22 base::string16* channel_name) override;
32 bool ShouldShowRestartDialog(base::string16* title, 23 bool ShouldShowRestartDialog(base::string16* title,
33 base::string16* message, 24 base::string16* message,
34 bool* is_rtl_locale) override; 25 bool* is_rtl_locale) override;
35 bool AboutToRestart() override; 26 bool AboutToRestart() override;
36 bool GetDeferredUploadsSupported(bool is_per_user_install) override; 27 bool GetDeferredUploadsSupported(bool is_per_user_install) override;
37 bool GetIsPerUserInstall(const base::FilePath& exe_path) override; 28 bool GetIsPerUserInstall(const base::FilePath& exe_path) override;
38 bool GetShouldDumpLargerDumps(bool is_per_user_install) override; 29 bool GetShouldDumpLargerDumps(bool is_per_user_install) override;
39 int GetResultCodeRespawnFailed() override; 30 int GetResultCodeRespawnFailed() override;
40 void InitBrowserCrashDumpsRegKey() override;
41 void RecordCrashDumpAttempt(bool is_real_crash) override;
42 void RecordCrashDumpAttemptResult(bool is_real_crash,
43 bool succeeded) override;
44 31
45 bool GetCrashDumpLocation(base::FilePath* crash_dir) override; 32 bool GetCrashDumpLocation(base::FilePath* crash_dir) override;
46 33
47 size_t RegisterCrashKeys() override; 34 size_t RegisterCrashKeys() override;
48 35
49 bool IsRunningUnattended() override; 36 bool IsRunningUnattended() override;
50 37
51 bool GetCollectStatsConsent() override; 38 bool GetCollectStatsConsent() override;
52 39
53 bool ReportingIsEnforcedByPolicy(bool* breakpad_enabled) override; 40 bool ReportingIsEnforcedByPolicy(bool* breakpad_enabled) override;
54 41
55 bool EnableBreakpadForProcess(const std::string& process_type) override; 42 bool EnableBreakpadForProcess(const std::string& process_type) override;
56 43
57 private: 44 private:
58 std::unique_ptr<browser_watcher::CrashReportingMetrics>
59 crash_reporting_metrics_;
60
61 DISALLOW_COPY_AND_ASSIGN(ChromeCrashReporterClient); 45 DISALLOW_COPY_AND_ASSIGN(ChromeCrashReporterClient);
62 }; 46 };
63 47
64 #endif // CHROME_APP_CHROME_CRASH_REPORTER_CLIENT_WIN_H_ 48 #endif // CHROME_APP_CHROME_CRASH_REPORTER_CLIENT_WIN_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/app/chrome_crash_reporter_client_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698