Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1922473002: Remove unnecessary ExceptionCode.h inclusion (Closed)

Created:
4 years, 8 months ago by Srirama
Modified:
4 years, 8 months ago
Reviewers:
haraken
CC:
chromium-reviews, ortuno+watch_chromium.org, shans, rjwright, tzik, blink-reviews-animation_chromium.org, blink-reviews-html_chromium.org, nhiroki, falken, kinuko+worker_chromium.org, dglazkov+blink, scheib+watch_chromium.org, blink-reviews-bindings_chromium.org, darktears, blink-reviews, horo+watch_chromium.org, kinuko+fileapi, blink-worker-reviews_chromium.org, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary ExceptionCode.h inclusion Though ExceptionCode.h is included, it's not used in some of the places CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/d48ae33df6ad22f1576681d2e4a1df774f8023c9 Cr-Commit-Position: refs/heads/master@{#389472}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMeterElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/NumberInputType.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/streams/ReadableStream.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceObserver.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/SharedWorker.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/Cache.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchManager.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/ResponseTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/EntrySync.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VRHardwareUnitCollection.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBEndpoint.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/AssertMatchingEnums.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Srirama
PTAL
4 years, 8 months ago (2016-04-25 12:56:38 UTC) #4
haraken
LGTM
4 years, 8 months ago (2016-04-25 12:59:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922473002/1
4 years, 8 months ago (2016-04-25 13:00:57 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-25 14:18:35 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 14:20:11 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d48ae33df6ad22f1576681d2e4a1df774f8023c9
Cr-Commit-Position: refs/heads/master@{#389472}

Powered by Google App Engine
This is Rietveld 408576698