Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1922463002: [NTP Snippets] Limit the number of snippets to 10 (Closed)

Created:
4 years, 8 months ago by Marc Treib
Modified:
4 years, 8 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, mcwilliams+watch_chromium.org, dgn+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Snippets] Limit the number of snippets to 10 BUG=603986 Committed: https://crrev.com/d3b0ca6ced3cddc24ef59a1c2702d2a846664294 Cr-Commit-Position: refs/heads/master@{#389464}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -8 lines) Patch
M components/ntp_snippets/ntp_snippets_fetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M components/ntp_snippets/ntp_snippets_fetcher.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service.cc View 4 chunks +14 lines, -2 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service_unittest.cc View 1 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922463002/1
4 years, 8 months ago (2016-04-25 10:11:13 UTC) #2
Marc Treib
PTAL!
4 years, 8 months ago (2016-04-25 10:19:20 UTC) #4
Bernhard Bauer
lgtm https://codereview.chromium.org/1922463002/diff/1/components/ntp_snippets/ntp_snippets_service_unittest.cc File components/ntp_snippets/ntp_snippets_service_unittest.cc (right): https://codereview.chromium.org/1922463002/diff/1/components/ntp_snippets/ntp_snippets_service_unittest.cc#newcode264 components/ntp_snippets/ntp_snippets_service_unittest.cc:264: std::string snippet_format = You could make this a ...
4 years, 8 months ago (2016-04-25 10:38:26 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-25 10:50:31 UTC) #7
Marc Treib
https://codereview.chromium.org/1922463002/diff/1/components/ntp_snippets/ntp_snippets_service_unittest.cc File components/ntp_snippets/ntp_snippets_service_unittest.cc (right): https://codereview.chromium.org/1922463002/diff/1/components/ntp_snippets/ntp_snippets_service_unittest.cc#newcode264 components/ntp_snippets/ntp_snippets_service_unittest.cc:264: std::string snippet_format = On 2016/04/25 10:38:25, Bernhard Bauer wrote: ...
4 years, 8 months ago (2016-04-25 11:21:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922463002/20001
4 years, 8 months ago (2016-04-25 11:22:11 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-25 13:35:36 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 13:36:46 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d3b0ca6ced3cddc24ef59a1c2702d2a846664294
Cr-Commit-Position: refs/heads/master@{#389464}

Powered by Google App Engine
This is Rietveld 408576698