[turbofan] Introduce Oddball::to_number_raw and use it for change lowering.

src/compiler/change-lowering.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/change-lowering.h"
 
 #include "src/address-map.h"
 #include "src/code-factory.h"
 #include "src/compiler/js-graph.h"
 #include "src/compiler/linkage.h"
@@ skipping 276 matching lines @@
       NodeProperties::GetType(value)->Is(Type::Number())) {
     return Replace(graph()->NewNode(op, LoadHeapNumberValue(value, control)));
   }
 
   Node* check = TestNotSmi(value);
   Node* branch =
       graph()->NewNode(common()->Branch(BranchHint::kFalse), check, control);
 
   Node* if_not_smi = graph()->NewNode(common()->IfTrue(), branch);
 
-  Node* vnot_smi;
-  if (NodeProperties::GetType(value)->Maybe(Type::Undefined())) {
-    Node* check_undefined = graph()->NewNode(machine()->WordEqual(), value,
-                                             jsgraph()->UndefinedConstant());
-    Node* branch_undefined = graph()->NewNode(
-        common()->Branch(BranchHint::kFalse), check_undefined, if_not_smi);
-
-    Node* if_undefined = graph()->NewNode(common()->IfTrue(), branch_undefined);
-    Node* vundefined = jsgraph()->Int32Constant(0);
-
-    Node* if_not_undefined =
-        graph()->NewNode(common()->IfFalse(), branch_undefined);
-    Node* vheap_number =
-        graph()->NewNode(op, LoadHeapNumberValue(value, if_not_undefined));
-
-    if_not_smi =
-        graph()->NewNode(common()->Merge(2), if_undefined, if_not_undefined);
-    vnot_smi =
-        graph()->NewNode(common()->Phi(MachineRepresentation::kWord32, 2),
-                         vundefined, vheap_number, if_not_smi);
-  } else {
-    vnot_smi = graph()->NewNode(op, LoadHeapNumberValue(value, if_not_smi));
-  }
+  STATIC_ASSERT(HeapNumber::kValueOffset == Oddball::kToNumberRawOffset);
+  Node* vnot_smi = graph()->NewNode(op, LoadHeapNumberValue(value, if_not_smi));
 
   Node* if_smi = graph()->NewNode(common()->IfFalse(), branch);
   Node* vfrom_smi = ChangeSmiToWord32(value);
 
   Node* merge = graph()->NewNode(common()->Merge(2), if_not_smi, if_smi);
   Node* phi = graph()->NewNode(common()->Phi(MachineRepresentation::kWord32, 2),
                                vnot_smi, vfrom_smi, merge);
 
   return Replace(phi);
 }
 
 
 Reduction ChangeLowering::ChangeTaggedToFloat64(Node* value, Node* control) {
   Node* check = TestNotSmi(value);
   Node* branch =
       graph()->NewNode(common()->Branch(BranchHint::kFalse), check, control);
 
   Node* if_not_smi = graph()->NewNode(common()->IfTrue(), branch);
 
-  Node* vnot_smi;
-  if (NodeProperties::GetType(value)->Maybe(Type::Undefined())) {
-    Node* check_undefined = graph()->NewNode(machine()->WordEqual(), value,
-                                             jsgraph()->UndefinedConstant());
-    Node* branch_undefined = graph()->NewNode(
-        common()->Branch(BranchHint::kFalse), check_undefined, if_not_smi);
-
-    Node* if_undefined = graph()->NewNode(common()->IfTrue(), branch_undefined);
-    Node* vundefined =
-        jsgraph()->Float64Constant(std::numeric_limits<double>::quiet_NaN());
-
-    Node* if_not_undefined =
-        graph()->NewNode(common()->IfFalse(), branch_undefined);
-    Node* vheap_number = LoadHeapNumberValue(value, if_not_undefined);
-
-    if_not_smi =
-        graph()->NewNode(common()->Merge(2), if_undefined, if_not_undefined);
-    vnot_smi =
-        graph()->NewNode(common()->Phi(MachineRepresentation::kFloat64, 2),
-                         vundefined, vheap_number, if_not_smi);
-  } else {
-    vnot_smi = LoadHeapNumberValue(value, if_not_smi);
-  }
+  STATIC_ASSERT(HeapNumber::kValueOffset == Oddball::kToNumberRawOffset);
+  Node* vnot_smi = LoadHeapNumberValue(value, if_not_smi);
 
   Node* if_smi = graph()->NewNode(common()->IfFalse(), branch);
   Node* vfrom_smi = ChangeSmiToFloat64(value);
 
   Node* merge = graph()->NewNode(common()->Merge(2), if_not_smi, if_smi);
   Node* phi =
       graph()->NewNode(common()->Phi(MachineRepresentation::kFloat64, 2),
                        vnot_smi, vfrom_smi, merge);
 
   return Replace(phi);
@@ skipping 20 matching lines @@
   return Replace(phi);
 }
 
 Reduction ChangeLowering::TruncateTaggedToWord32(Node* value, Node* control) {
   Node* check = TestNotSmi(value);
   Node* branch =
       graph()->NewNode(common()->Branch(BranchHint::kFalse), check, control);
 
   Node* if_not_smi = graph()->NewNode(common()->IfTrue(), branch);
 
-  Node* vnot_smi;
-  if (NodeProperties::GetType(value)->Maybe(Type::Undefined())) {
-    Node* check_undefined = graph()->NewNode(machine()->WordEqual(), value,
-                                             jsgraph()->UndefinedConstant());
-    Node* branch_undefined = graph()->NewNode(
-        common()->Branch(BranchHint::kFalse), check_undefined, if_not_smi);
-
-    Node* if_undefined = graph()->NewNode(common()->IfTrue(), branch_undefined);
-    Node* vundefined = jsgraph()->Int32Constant(0);
-
-    Node* if_not_undefined =
-        graph()->NewNode(common()->IfFalse(), branch_undefined);
-    Node* vheap_number =
-        graph()->NewNode(machine()->TruncateFloat64ToWord32(),
-                         LoadHeapNumberValue(value, if_not_undefined));
-
-    if_not_smi =
-        graph()->NewNode(common()->Merge(2), if_undefined, if_not_undefined);
-    vnot_smi =
-        graph()->NewNode(common()->Phi(MachineRepresentation::kWord32, 2),
-                         vundefined, vheap_number, if_not_smi);
-  } else {
-    vnot_smi = graph()->NewNode(machine()->TruncateFloat64ToWord32(),
-                                LoadHeapNumberValue(value, if_not_smi));
-  }
+  STATIC_ASSERT(HeapNumber::kValueOffset == Oddball::kToNumberRawOffset);
+  Node* vnot_smi = graph()->NewNode(machine()->TruncateFloat64ToWord32(),
+                                    LoadHeapNumberValue(value, if_not_smi));
 
   Node* if_smi = graph()->NewNode(common()->IfFalse(), branch);
   Node* vfrom_smi = ChangeSmiToWord32(value);
 
   Node* merge = graph()->NewNode(common()->Merge(2), if_not_smi, if_smi);
   Node* phi = graph()->NewNode(common()->Phi(MachineRepresentation::kWord32, 2),
                                vnot_smi, vfrom_smi, merge);
 
   return Replace(phi);
 }
@@ skipping 299 matching lines @@
 }
 
 
 MachineOperatorBuilder* ChangeLowering::machine() const {
   return jsgraph()->machine();
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8