Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1922443002: [turbofan] Introduce Oddball::to_number_raw and use it for change lowering. (Closed)

Created:
4 years, 8 months ago by Benedikt Meurer
Modified:
4 years, 7 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce Oddball::to_number_raw and use it for change lowering. The Oddball::to_number_raw field contains the actual double value of the Oddball converted to a number, and is located at the same offset as the HeapNumber::value field, so for lowering changes we don't need to check for undefined (or any other oddball explicitly). R=jarin@chromium.org Committed: https://crrev.com/d1fb8384e02be1904e6a4e033ec1d3a6053a53f5 Cr-Commit-Position: refs/heads/master@{#35753}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -73 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/change-lowering.cc View 3 chunks +7 lines, -71 lines 0 comments Download
M src/objects.h View 3 chunks +7 lines, -1 line 0 comments Download
M src/objects.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
4 years, 8 months ago (2016-04-25 08:42:48 UTC) #1
Jarin
lgtm
4 years, 8 months ago (2016-04-25 08:48:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922443002/1
4 years, 8 months ago (2016-04-25 08:50:09 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-25 09:17:06 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 09:18:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1fb8384e02be1904e6a4e033ec1d3a6053a53f5
Cr-Commit-Position: refs/heads/master@{#35753}

Powered by Google App Engine
This is Rietveld 408576698