Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Issue 1922413002: [js-perf-test] Shorten output of JSTests/PropertyQueries microbenchmark. (Closed)

Created:
4 years, 7 months ago by Igor Sheludko
Modified:
4 years, 7 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[js-perf-test] Shorten output of JSTests/PropertyQueries microbenchmark. Committed: https://crrev.com/2fb88d617c45bb26392a407d79428faaf70ca5d3 Cr-Commit-Position: refs/heads/master@{#35810}

Patch Set 1 #

Patch Set 2 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -124 lines) Patch
M test/js-perf-test/JSTests.json View 1 1 chunk +14 lines, -56 lines 0 comments Download
M test/js-perf-test/PropertyQueries/PropertyQueries.json View 1 1 chunk +14 lines, -56 lines 0 comments Download
M test/js-perf-test/PropertyQueries/property-queries.js View 1 3 chunks +11 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Igor Sheludko
PTAL Now the output looks like this: in--INTRN-prop-PropertyQueries(Score): 21018 in--DEINTRN-prop-PropertyQueries(Score): 10159 in--NE-INTRN-prop-PropertyQueries(Score): 2175 in--NE-DEINTRN-prop-PropertyQueries(Score): 1790 ...
4 years, 7 months ago (2016-04-27 08:46:36 UTC) #2
Toon Verwaest
lgtm, kinda silly to drop the E from intern :)
4 years, 7 months ago (2016-04-27 08:52:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922413002/20001
4 years, 7 months ago (2016-04-27 08:56:04 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-27 09:13:20 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 09:14:21 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2fb88d617c45bb26392a407d79428faaf70ca5d3
Cr-Commit-Position: refs/heads/master@{#35810}

Powered by Google App Engine
This is Rietveld 408576698