Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1922403002: Move bool enable_brotli from HttpNetworkSession::Params (Closed)

Created:
4 years, 7 months ago by maksims (do not use this acc)
Modified:
4 years, 7 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move bool enable_brotli from HttpNetworkSession::Params Moving bool enable_brotli from HttpNetoworkSession::Params to URLRequestContext. Brotli is set on thread initialization and profileiodata initialization. Then it is propagated to other contexts through URLRequestContext::CopyFrom method. BUG=600450 Committed: https://crrev.com/3d40c8112303a985fab79c74e92e9a79fc4ac9f9 Cr-Commit-Position: refs/heads/master@{#390930}

Patch Set 1 #

Patch Set 2 : unittest fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -11 lines) Patch
M chrome/browser/io_thread.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/io_thread.cc View 4 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/http/http_network_session.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/http/http_network_session.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/url_request/url_request_context.h View 2 chunks +7 lines, -0 lines 0 comments Download
M net/url_request/url_request_context.cc View 2 chunks +3 lines, -1 line 0 comments Download
M net/url_request/url_request_http_job.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/url_request/url_request_http_job_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 39 (22 generated)
maksims (do not use this acc)
ptal.
4 years, 7 months ago (2016-04-27 07:38:21 UTC) #5
mmenke
On 2016/04/27 07:38:21, maksims wrote: > ptal. LGTM!
4 years, 7 months ago (2016-04-27 15:02:04 UTC) #6
mmenke
On 2016/04/27 15:02:04, mmenke wrote: > On 2016/04/27 07:38:21, maksims wrote: > > ptal. > ...
4 years, 7 months ago (2016-04-27 15:02:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922403002/1
4 years, 7 months ago (2016-04-28 04:40:43 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/152223)
4 years, 7 months ago (2016-04-28 04:50:54 UTC) #11
maksims (do not use this acc)
On 2016/04/27 15:02:04, mmenke wrote: > On 2016/04/27 07:38:21, maksims wrote: > > ptal. > ...
4 years, 7 months ago (2016-04-28 04:54:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922403002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922403002/40001
4 years, 7 months ago (2016-04-28 05:14:57 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn/builds/26564)
4 years, 7 months ago (2016-04-28 05:22:40 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/182012) win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, ...
4 years, 7 months ago (2016-04-28 05:23:00 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922403002/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922403002/50001
4 years, 7 months ago (2016-05-02 11:48:06 UTC) #21
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/28025)
4 years, 7 months ago (2016-05-02 11:58:52 UTC) #23
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922403002/70001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922403002/70001
4 years, 7 months ago (2016-05-02 12:04:47 UTC) #26
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/153838)
4 years, 7 months ago (2016-05-02 12:15:44 UTC) #28
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922403002/90001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922403002/90001
4 years, 7 months ago (2016-05-02 12:20:37 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922403002/90001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922403002/90001
4 years, 7 months ago (2016-05-02 12:34:49 UTC) #35
commit-bot: I haz the power
Committed patchset #2 (id:90001)
4 years, 7 months ago (2016-05-02 13:27:26 UTC) #37
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 13:28:49 UTC) #39
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3d40c8112303a985fab79c74e92e9a79fc4ac9f9
Cr-Commit-Position: refs/heads/master@{#390930}

Powered by Google App Engine
This is Rietveld 408576698