Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp

Issue 1922393002: CC Animation: Unify ElementId in Blink Compositor Worker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@player
Patch Set: Remove NextElementId. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp b/third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp
index c405ad1cce1f641d4f02b4f2cbd1bd39df321816..bec1d2b4abd17cc4431876b812c3100a4b6bfdd4 100644
--- a/third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp
+++ b/third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp
@@ -140,19 +140,19 @@ TEST_F(CompositorWorkerTest, plumbingElementIdAndMutableProperties)
WebLayer* proxiedLayer = webLayerFromElement(proxiedElement);
EXPECT_TRUE(proxiedLayer->compositorMutableProperties() & CompositorMutableProperty::kTransform);
EXPECT_FALSE(proxiedLayer->compositorMutableProperties() & (CompositorMutableProperty::kScrollLeft | CompositorMutableProperty::kScrollTop | CompositorMutableProperty::kOpacity));
- EXPECT_NE(0UL, proxiedLayer->elementId());
+ EXPECT_NE(0, proxiedLayer->elementId());
Element* scrollElement = document->getElementById("proxied-scroller");
WebLayer* scrollLayer = scrollingWebLayerFromElement(scrollElement);
EXPECT_TRUE(scrollLayer->compositorMutableProperties() & (CompositorMutableProperty::kScrollLeft | CompositorMutableProperty::kScrollTop));
EXPECT_FALSE(scrollLayer->compositorMutableProperties() & (CompositorMutableProperty::kTransform | CompositorMutableProperty::kOpacity));
- EXPECT_NE(0UL, scrollLayer->elementId());
+ EXPECT_NE(0, scrollLayer->elementId());
WebLayer* rootScrollLayer = getRootScrollLayer();
EXPECT_TRUE(rootScrollLayer->compositorMutableProperties() & (CompositorMutableProperty::kScrollLeft | CompositorMutableProperty::kScrollTop));
EXPECT_FALSE(rootScrollLayer->compositorMutableProperties() & (CompositorMutableProperty::kTransform | CompositorMutableProperty::kOpacity));
- EXPECT_NE(0UL, rootScrollLayer->elementId());
+ EXPECT_NE(0, rootScrollLayer->elementId());
}
TEST_F(CompositorWorkerTest, noProxies)
@@ -177,11 +177,11 @@ TEST_F(CompositorWorkerTest, noProxies)
Element* scrollElement = document->getElementById("proxied-scroller");
WebLayer* scrollLayer = scrollingWebLayerFromElement(scrollElement);
EXPECT_FALSE(!!scrollLayer->compositorMutableProperties());
- EXPECT_EQ(0UL, scrollLayer->elementId());
+ EXPECT_EQ(0, scrollLayer->elementId());
WebLayer* rootScrollLayer = getRootScrollLayer();
EXPECT_FALSE(!!rootScrollLayer->compositorMutableProperties());
- EXPECT_EQ(0UL, rootScrollLayer->elementId());
+ EXPECT_EQ(0, rootScrollLayer->elementId());
}
TEST_F(CompositorWorkerTest, disconnectedProxies)
@@ -206,11 +206,11 @@ TEST_F(CompositorWorkerTest, disconnectedProxies)
Element* scrollElement = document->getElementById("proxied-scroller");
WebLayer* scrollLayer = scrollingWebLayerFromElement(scrollElement);
EXPECT_FALSE(!!scrollLayer->compositorMutableProperties());
- EXPECT_EQ(0UL, scrollLayer->elementId());
+ EXPECT_EQ(0, scrollLayer->elementId());
WebLayer* rootScrollLayer = getRootScrollLayer();
EXPECT_FALSE(!!rootScrollLayer->compositorMutableProperties());
- EXPECT_EQ(0UL, rootScrollLayer->elementId());
+ EXPECT_EQ(0, rootScrollLayer->elementId());
}
TEST_F(CompositorWorkerTest, applyingMutationsMultipleElements)
@@ -227,8 +227,8 @@ TEST_F(CompositorWorkerTest, applyingMutationsMultipleElements)
WebLayer* proxiedLayer = webLayerFromElement(proxiedElement);
EXPECT_TRUE(proxiedLayer->compositorMutableProperties() & CompositorMutableProperty::kTransform);
EXPECT_FALSE(proxiedLayer->compositorMutableProperties() & (CompositorMutableProperty::kScrollLeft | CompositorMutableProperty::kScrollTop | CompositorMutableProperty::kOpacity));
- uint64_t elementId = proxiedLayer->elementId();
- EXPECT_NE(0UL, elementId);
+ CompositorElementId elementId = proxiedLayer->elementId();
+ EXPECT_NE(0, elementId);
TransformationMatrix transformMatrix(11, 12, 13, 14, 21, 22, 23, 24, 31, 32, 33, 34, 41, 42, 43, 44);
CompositorMutation mutation;
@@ -245,8 +245,8 @@ TEST_F(CompositorWorkerTest, applyingMutationsMultipleElements)
WebLayer* proxiedLayer = webLayerFromElement(proxiedElement);
EXPECT_TRUE(proxiedLayer->compositorMutableProperties() & CompositorMutableProperty::kOpacity);
EXPECT_FALSE(proxiedLayer->compositorMutableProperties() & (CompositorMutableProperty::kScrollLeft | CompositorMutableProperty::kScrollTop | CompositorMutableProperty::kTransform));
- uint64_t elementId = proxiedLayer->elementId();
- EXPECT_NE(0UL, elementId);
+ CompositorElementId elementId = proxiedLayer->elementId();
+ EXPECT_NE(0, elementId);
CompositorMutation mutation;
mutation.setOpacity(0.5);
@@ -273,8 +273,8 @@ TEST_F(CompositorWorkerTest, applyingMutationsMultipleProperties)
EXPECT_TRUE(proxiedLayer->compositorMutableProperties() & CompositorMutableProperty::kTransform);
EXPECT_TRUE(proxiedLayer->compositorMutableProperties() & CompositorMutableProperty::kOpacity);
EXPECT_FALSE(proxiedLayer->compositorMutableProperties() & (CompositorMutableProperty::kScrollLeft | CompositorMutableProperty::kScrollTop));
- uint64_t elementId = proxiedLayer->elementId();
- EXPECT_NE(0UL, elementId);
+ CompositorElementId elementId = proxiedLayer->elementId();
+ EXPECT_NE(0, elementId);
TransformationMatrix transformMatrix(11, 12, 13, 14, 21, 22, 23, 24, 31, 32, 33, 34, 41, 42, 43, 44);
OwnPtr<CompositorMutation> mutation = adoptPtr(new CompositorMutation);
« no previous file with comments | « third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp ('k') | third_party/WebKit/public/platform/WebLayer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698