third_party/WebKit/Source/core/dom/CompositorProxy.cpp - Issue 1922393002: CC Animation: Unify ElementId in Blink Compositor Worker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/CompositorProxy.cpp

Issue 1922393002: CC Animation: Unify ElementId in Blink Compositor Worker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@player

Patch Set: Remove NextElementId. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/CompositorProxy.h ('k') | third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/CompositorProxy.cpp

diff --git a/third_party/WebKit/Source/core/dom/CompositorProxy.cpp b/third_party/WebKit/Source/core/dom/CompositorProxy.cpp

index fd5ae040a01d31bbdd2c5275fa63c9f58ea9ad29..7ab544c2acc8294d689d3837f93bbf50d7134abb 100644

--- a/third_party/WebKit/Source/core/dom/CompositorProxy.cpp

+++ b/third_party/WebKit/Source/core/dom/CompositorProxy.cpp

@@ -47,7 +47,7 @@ static bool isCallingCompositorFrameCallback()

return true;

}

-static void decrementCompositorProxiedPropertiesForElement(uint64_t elementId, uint32_t compositorMutableProperties)

+static void decrementCompositorProxiedPropertiesForElement(CompositorElementId elementId, uint32_t compositorMutableProperties)

{

DCHECK(isMainThread());

Node* node = DOMNodeIds::nodeForId(elementId);

@@ -57,7 +57,7 @@ static void decrementCompositorProxiedPropertiesForElement(uint64_t elementId, u

element->decrementCompositorProxiedProperties(compositorMutableProperties);

}

-static void incrementCompositorProxiedPropertiesForElement(uint64_t elementId, uint32_t compositorMutableProperties)

+static void incrementCompositorProxiedPropertiesForElement(CompositorElementId elementId, uint32_t compositorMutableProperties)

{

DCHECK(isMainThread());

Node* node = DOMNodeIds::nodeForId(elementId);

@@ -112,7 +112,7 @@ CompositorProxy* CompositorProxy::create(ExecutionContext* context, Element* ele

return new CompositorProxy(*element, attributeArray);

}

-CompositorProxy* CompositorProxy::create(uint64_t elementId, uint32_t compositorMutableProperties)

+CompositorProxy* CompositorProxy::create(CompositorElementId elementId, uint32_t compositorMutableProperties)

{

return new CompositorProxy(elementId, compositorMutableProperties);

}

@@ -130,7 +130,7 @@ CompositorProxy::CompositorProxy(Element& element, const Vector<String>& attribu

incrementCompositorProxiedPropertiesForElement(m_elementId, m_compositorMutableProperties);

}

-CompositorProxy::CompositorProxy(uint64_t elementId, uint32_t compositorMutableProperties)

+CompositorProxy::CompositorProxy(CompositorElementId elementId, uint32_t compositorMutableProperties)

: m_elementId(elementId)

, m_compositorMutableProperties(compositorMutableProperties)

{