Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Issue 1922373003: Revert of Use visual studio toolchain from depot_tools for PDFium compilation (Closed)

Created:
4 years, 7 months ago by Wei Li
Modified:
4 years, 7 months ago
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert of Use visual studio toolchain from depot_tools for PDFium compilation (patchset #3 id:40001 of https://codereview.chromium.org/1897523002/ ) Reason for revert: Clang build is broken. drm build has some problem. Will revert this change for now. Original issue's description: > Use visual studio toolchain from depot_tools for PDFium compilation > > Change to use visual studio toolchain from depot_tools by default. > Setting DEPOT_TOOLS_WIN_TOOLCHAIN=0 allows compilation using system > toolchain as before. > > Using toolchain from depot_tools unifies the compilation > environment, and brings the benefits of automated update, bug fixes > etc. > > Committed: https://pdfium.googlesource.com/pdfium/+/590f2d9e057a0d5b17a9706affd3c6115265021b TBR=brucedawson@chromium.org,thestig@chromium.org,tsepez@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://pdfium.googlesource.com/pdfium/+/df96690d4e3799536b981e3673d64018fa5fd037

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -460 lines) Patch
M .gitignore View 1 chunk +0 lines, -1 line 0 comments Download
M DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
D build_gyp/find_depot_tools.py View 1 chunk +0 lines, -60 lines 0 comments Download
M build_gyp/gyp_pdfium View 3 chunks +2 lines, -15 lines 0 comments Download
D build_gyp/vs_toolchain.py View 1 chunk +0 lines, -378 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Wei Li
Created Revert of Use visual studio toolchain from depot_tools for PDFium compilation
4 years, 7 months ago (2016-04-27 23:14:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922373003/1
4 years, 7 months ago (2016-04-27 23:14:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/df96690d4e3799536b981e3673d64018fa5fd037
4 years, 7 months ago (2016-04-27 23:14:39 UTC) #4
Wei Li
4 years, 7 months ago (2016-04-28 22:26:28 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1927373002/ by weili@chromium.org.

The reason for reverting is: I fixed Clang build config, and updated drm binary.
Should work this time..

Powered by Google App Engine
This is Rietveld 408576698