Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: ui/gfx/gfx.gyp

Issue 1922373002: Make ui/gfx/range a component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed windows issues + addressed nit Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/BUILD.gn ('k') | ui/gfx/gfx_tests.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/gfx.gyp
diff --git a/ui/gfx/gfx.gyp b/ui/gfx/gfx.gyp
index c648d303d18fd2c0935e0b2453bca433b8d66147..d88ce96fdb0777ef8e0d17fe085a0ec35d2b1e3b 100644
--- a/ui/gfx/gfx.gyp
+++ b/ui/gfx/gfx.gyp
@@ -68,6 +68,33 @@
],
},
{
+ 'target_name': 'gfx_range',
+ 'type': '<(component)',
+ 'dependencies': [
+ '<(DEPTH)/base/base.gyp:base',
+ ],
+ 'defines': [
+ 'GFX_RANGE_IMPLEMENTATION',
+ ],
+ 'sources': [
+ 'range/gfx_range_export.h',
+ 'range/range.cc',
+ 'range/range.h',
+ 'range/range_f.cc',
+ 'range/range_f.h',
+ 'range/range_mac.mm',
+ 'range/range_win.cc',
+ ],
+ 'conditions': [
+ ['OS=="win"', {
+ # TODO(jschuh): C4267: http://crbug.com/167187 size_t -> int
+ # C4324 is structure was padded due to __declspec(align()), which is
+ # uninteresting.
+ 'msvs_disabled_warnings': [ 4267, 4324 ],
+ }],
+ ]
+ },
+ {
'target_name': 'gfx',
'type': '<(component)',
'dependencies': [
@@ -82,6 +109,7 @@
'<(DEPTH)/third_party/libpng/libpng.gyp:libpng',
'<(DEPTH)/third_party/zlib/zlib.gyp:zlib',
'gfx_geometry',
+ 'gfx_range',
],
# text_elider.h includes ICU headers.
'export_dependent_settings': [
@@ -251,12 +279,6 @@
'platform_font_mac.mm',
'platform_font_win.cc',
'platform_font_win.h',
- 'range/range.cc',
- 'range/range.h',
- 'range/range_f.cc',
- 'range/range_f.h',
- 'range/range_mac.mm',
- 'range/range_win.cc',
'render_text.cc',
'render_text.h',
'render_text_harfbuzz.cc',
« no previous file with comments | « ui/gfx/BUILD.gn ('k') | ui/gfx/gfx_tests.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698