Make ui/gfx/range a component

ui/gfx/gfx.gyp

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
   },
   'targets': [
     {
@@ skipping 50 matching lines @@
         'geometry/vector2d_f.cc',
         'geometry/vector2d_f.h',
         'geometry/vector3d_f.cc',
         'geometry/vector3d_f.h',
       ],
       'includes': [
         '../../build/android/increase_size_for_speed.gypi',
       ],
     },
     {
+      'target_name': 'gfx_range',
+      'type': '<(component)',
+      'dependencies': [
+        '<(DEPTH)/base/base.gyp:base',
+      ],
+      'defines': [
+        'GFX_IMPLEMENTATION',

[sky, 2016/04/27 16:51:30]

Don't you need a separate macro for the range files? Otherwise if something from
ui/gfx happens to include ui/gfx/range then you'll get the wrong define set.

[Fady Samuel, 2016/04/27 17:16:59]

Done.

+      ],
+      'sources': [
+        'range/range.cc',
+        'range/range.h',
+        'range/range_f.cc',
+        'range/range_f.h',
+        'range/range_mac.mm',
+        'range/range_win.cc',
+      ],
+      'conditions': [
+        ['OS=="win"', {
+          # TODO(jschuh): C4267: http://crbug.com/167187 size_t -> int
+          # C4324 is structure was padded due to __declspec(align()), which is
+          # uninteresting.
+          'msvs_disabled_warnings': [ 4267, 4324 ],
+        }],
+      ]
+    },
+    {
       'target_name': 'gfx',
       'type': '<(component)',
       'dependencies': [
         '<(DEPTH)/base/base.gyp:base',
         '<(DEPTH)/base/base.gyp:base_i18n',
         '<(DEPTH)/base/base.gyp:base_static',
         '<(DEPTH)/base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
         '<(DEPTH)/skia/skia.gyp:skia',
         '<(DEPTH)/third_party/harfbuzz-ng/harfbuzz.gyp:harfbuzz-ng',
         '<(DEPTH)/third_party/icu/icu.gyp:icui18n',
         '<(DEPTH)/third_party/icu/icu.gyp:icuuc',
         '<(DEPTH)/third_party/libpng/libpng.gyp:libpng',
         '<(DEPTH)/third_party/zlib/zlib.gyp:zlib',
         'gfx_geometry',
+        'gfx_range',
       ],
       # text_elider.h includes ICU headers.
       'export_dependent_settings': [
         '<(DEPTH)/skia/skia.gyp:skia',
         '<(DEPTH)/third_party/icu/icu.gyp:icui18n',
         '<(DEPTH)/third_party/icu/icu.gyp:icuuc',
       ],
       'defines': [
         'GFX_IMPLEMENTATION',
       ],
@@ skipping 149 matching lines @@
         'platform_font.h',
         'platform_font_android.cc',
         'platform_font_ios.h',
         'platform_font_ios.mm',
         'platform_font_linux.cc',
         'platform_font_linux.h',
         'platform_font_mac.h',
         'platform_font_mac.mm',
         'platform_font_win.cc',
         'platform_font_win.h',
-        'range/range.cc',
-        'range/range.h',
-        'range/range_f.cc',
-        'range/range_f.h',
-        'range/range_mac.mm',
-        'range/range_win.cc',
         'render_text.cc',
         'render_text.h',
         'render_text_harfbuzz.cc',
         'render_text_harfbuzz.h',
         'render_text_mac.h',
         'render_text_mac.mm',
         'scoped_canvas.h',
         'scoped_cg_context_save_gstate_mac.h',
         'scoped_ns_graphics_context_save_gstate_mac.h',
         'scoped_ns_graphics_context_save_gstate_mac.mm',
@@ skipping 309 matching lines @@
          ],
          'variables': {
            'jni_gen_package': 'ui/gfx',
          },
          'includes': [ '../../build/jni_generator.gypi' ],
        },
      ],
     }],
   ],
 }