Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/Dialog.js

Issue 1922303004: DevTools: fix focus restoration from command menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed to stricter jsdoc Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/ui/Dialog.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js b/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js
index fb24054e2b1d37c9310d8bb171060efd496cb07c..2fa46c1052653a502164f9d8413d6a5e9dc475d8 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js
@@ -73,7 +73,7 @@ WebInspector.Dialog.prototype = {
this._glassPane = new WebInspector.GlassPane(document, this._dimmed);
this._glassPane.element.addEventListener("click", this._onGlassPaneClick.bind(this), false);
- WebInspector.GlassPane.DefaultFocusedViewStack.push(this);
+ WebInspector.GlassPane.DefaultFocusedViewStack.push(WebInspector.currentFocusElement() || WebInspector.inspectorView);
dgozman 2016/04/28 01:28:29 This makes me think whether we should unify Defaul
WebInspector.Widget.prototype.show.call(this, this._glassPane.element);
@@ -87,9 +87,8 @@ WebInspector.Dialog.prototype = {
detach: function()
{
WebInspector.Widget.prototype.detach.call(this);
-
- WebInspector.GlassPane.DefaultFocusedViewStack.pop();
this._glassPane.dispose();
+ WebInspector.GlassPane.DefaultFocusedViewStack.pop();
delete this._glassPane;
this._restoreTabIndexOnElements();
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698