Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1922303004: DevTools: fix focus restoration from command menu (Closed)

Created:
4 years, 7 months ago by luoe
Modified:
4 years, 7 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix focus restoration from command menu BUG=604427 Committed: https://crrev.com/0a0b2833b563519dbade8923c6fde6c75c728ea8 Cr-Commit-Position: refs/heads/master@{#391057}

Patch Set 1 #

Patch Set 2 : Fixed to stricter jsdoc #

Total comments: 1

Patch Set 3 : Replace stack with hasInstance #

Total comments: 1

Patch Set 4 : Remove unnecessary !! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/Dialog.js View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ShortcutRegistry.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js View 1 2 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
luoe
Formerly: Dialog.js’s show() stack.push(this) ← Dialog Dialog.js’s detach() Dialog.js’s .pop() UIUtils.js’s .dispose() stack.peekLast().focus() ← This ...
4 years, 7 months ago (2016-04-27 23:08:16 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922303004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922303004/20001
4 years, 7 months ago (2016-04-27 23:18:35 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-28 00:52:01 UTC) #6
dgozman
https://codereview.chromium.org/1922303004/diff/20001/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js File third_party/WebKit/Source/devtools/front_end/ui/Dialog.js (right): https://codereview.chromium.org/1922303004/diff/20001/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js#newcode76 third_party/WebKit/Source/devtools/front_end/ui/Dialog.js:76: WebInspector.GlassPane.DefaultFocusedViewStack.push(WebInspector.currentFocusElement() || WebInspector.inspectorView); This makes me think whether we ...
4 years, 7 months ago (2016-04-28 01:28:29 UTC) #7
luoe
Okay, the DefaultFocusedViewStack is gone. The shortcutRegistry now checks WI.Dialog.hasInstance to determine whether the dialog ...
4 years, 7 months ago (2016-05-02 17:30:14 UTC) #8
pfeldman
lgtm https://codereview.chromium.org/1922303004/diff/40001/third_party/WebKit/Source/devtools/front_end/ui/ShortcutRegistry.js File third_party/WebKit/Source/devtools/front_end/ui/ShortcutRegistry.js (right): https://codereview.chromium.org/1922303004/diff/40001/third_party/WebKit/Source/devtools/front_end/ui/ShortcutRegistry.js#newcode93 third_party/WebKit/Source/devtools/front_end/ui/ShortcutRegistry.js:93: if (!!WebInspector.Dialog.hasInstance()) { no need for !!
4 years, 7 months ago (2016-05-02 18:50:26 UTC) #10
luoe
On 2016/05/02 18:50:26, pfeldman wrote: > lgtm > > https://codereview.chromium.org/1922303004/diff/40001/third_party/WebKit/Source/devtools/front_end/ui/ShortcutRegistry.js > File third_party/WebKit/Source/devtools/front_end/ui/ShortcutRegistry.js > (right): ...
4 years, 7 months ago (2016-05-02 19:16:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922303004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922303004/60001
4 years, 7 months ago (2016-05-02 19:19:18 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922303004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922303004/60001
4 years, 7 months ago (2016-05-02 21:27:54 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-02 21:33:08 UTC) #18
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/0a0b2833b563519dbade8923c6fde6c75c728ea8 Cr-Commit-Position: refs/heads/master@{#391057}
4 years, 7 months ago (2016-05-02 21:34:15 UTC) #20
pfeldman
4 years, 7 months ago (2016-05-03 21:14:34 UTC) #21
Message was sent while issue was closed. 
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1944993002/ by pfeldman@chromium.org.

The reason for reverting is: Breaks focus from Cmd+P.

Powered by Google App Engine
This is Rietveld 408576698