Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3674)

Unified Diff: src/libsampler/v8-sampler.cc

Issue 1922303002: Create libsampler as V8 sampler library. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix TSAN failure Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/libsampler/v8-sampler.h ('k') | src/log.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/libsampler/v8-sampler.cc
diff --git a/src/profiler/sampler.cc b/src/libsampler/v8-sampler.cc
similarity index 48%
rename from src/profiler/sampler.cc
rename to src/libsampler/v8-sampler.cc
index ae47dca1504ed094448329f7b163450ee96016d0..f4bf7b1a48a6475dddc1ba0d964d202ed565ba3a 100644
--- a/src/profiler/sampler.cc
+++ b/src/libsampler/v8-sampler.cc
@@ -1,8 +1,8 @@
-// Copyright 2013 the V8 project authors. All rights reserved.
+// Copyright 2016 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "src/profiler/sampler.h"
+#include "src/libsampler/v8-sampler.h"
#if V8_OS_POSIX && !V8_OS_CYGWIN
@@ -42,12 +42,13 @@
#endif
+#include <algorithm>
+#include <vector>
+#include <map>
+
#include "src/base/atomic-utils.h"
#include "src/base/platform/platform.h"
-#include "src/profiler/cpu-profiler-inl.h"
-#include "src/profiler/tick-sample.h"
-#include "src/simulator.h"
-#include "src/v8threads.h"
+#include "src/libsampler/hashmap.h"
#if V8_OS_ANDROID && !defined(__BIONIC_HAVE_UCONTEXT_T)
@@ -155,26 +156,14 @@ enum { REG_RBP = 10, REG_RSP = 15, REG_RIP = 16 };
namespace v8 {
-namespace internal {
+namespace sampler {
namespace {
-class PlatformDataCommon : public Malloced {
- public:
- PlatformDataCommon() : profiled_thread_id_(ThreadId::Current()) {}
- ThreadId profiled_thread_id() { return profiled_thread_id_; }
-
- protected:
- ~PlatformDataCommon() {}
-
- private:
- ThreadId profiled_thread_id_;
-};
-
-
-typedef List<Sampler*> SamplerList;
-
#if defined(USE_SIGNALS)
+typedef std::vector<Sampler*> SamplerList;
+typedef SamplerList::iterator SamplerListIterator;
+
class AtomicGuard {
public:
explicit AtomicGuard(base::AtomicValue<int>* atomic, bool is_block = true)
@@ -216,13 +205,14 @@ uint32_t ThreadHash(pthread_t thread_id) {
return static_cast<uint32_t>(thread_id);
#endif
}
+
#endif // USE_SIGNALS
} // namespace
#if defined(USE_SIGNALS)
-class Sampler::PlatformData : public PlatformDataCommon {
+class Sampler::PlatformData {
public:
PlatformData() : vm_tid_(pthread_self()) {}
pthread_t vm_tid() const { return vm_tid_; }
@@ -231,13 +221,85 @@ class Sampler::PlatformData : public PlatformDataCommon {
pthread_t vm_tid_;
};
+
+class SamplerManager {
+ public:
+ static void AddSampler(Sampler* sampler) {
+ AtomicGuard atomic_guard(&samplers_access_counter_);
+ DCHECK(sampler->IsActive() || !sampler->IsRegistered());
+ // Add sampler into map if needed.
+ pthread_t thread_id = sampler->platform_data()->vm_tid();
+ HashMap::Entry* entry =
+ sampler_map_.Pointer()->LookupOrInsert(ThreadKey(thread_id),
+ ThreadHash(thread_id));
+ DCHECK(entry != NULL);
+ if (entry->value == NULL) {
+ SamplerList* samplers = new SamplerList();
+ samplers->push_back(sampler);
+ entry->value = samplers;
+ } else {
+ SamplerList* samplers = reinterpret_cast<SamplerList*>(entry->value);
+ bool exists = false;
+ for (SamplerListIterator iter = samplers->begin();
+ iter != samplers->end(); ++iter) {
+ if (*iter == sampler) {
+ exists = true;
+ break;
+ }
+ }
+ if (!exists) {
+ samplers->push_back(sampler);
+ }
+ }
+ }
+
+ static void RemoveSampler(Sampler* sampler) {
+ AtomicGuard atomic_guard(&samplers_access_counter_);
+ DCHECK(sampler->IsActive() || sampler->IsRegistered());
+ // Remove sampler from map.
+ pthread_t thread_id = sampler->platform_data()->vm_tid();
+ void* thread_key = ThreadKey(thread_id);
+ uint32_t thread_hash = ThreadHash(thread_id);
+ HashMap::Entry* entry = sampler_map_.Get().Lookup(thread_key, thread_hash);
+ DCHECK(entry != NULL);
+ SamplerList* samplers = reinterpret_cast<SamplerList*>(entry->value);
+ for (SamplerListIterator iter = samplers->begin(); iter != samplers->end();
+ ++iter) {
+ if (*iter == sampler) {
+ samplers->erase(iter);
+ break;
+ }
+ }
+ if (samplers->empty()) {
+ sampler_map_.Pointer()->Remove(thread_key, thread_hash);
+ delete samplers;
+ }
+ }
+
+ private:
+ struct HashMapCreateTrait {
+ static void Construct(HashMap* allocated_ptr) {
+ new (allocated_ptr) HashMap(HashMap::PointersMatch);
+ }
+ };
+ friend class SignalHandler;
+ static base::LazyInstance<HashMap, HashMapCreateTrait>::type
+ sampler_map_;
+ static base::AtomicValue<int> samplers_access_counter_;
+};
+
+base::LazyInstance<HashMap, SamplerManager::HashMapCreateTrait>::type
+ SamplerManager::sampler_map_ = LAZY_INSTANCE_INITIALIZER;
+base::AtomicValue<int> SamplerManager::samplers_access_counter_(0);
+
+
#elif V8_OS_WIN || V8_OS_CYGWIN
// ----------------------------------------------------------------------------
// Win32 profiler support. On Cygwin we use the same sampler implementation as
// on Win32.
-class Sampler::PlatformData : public PlatformDataCommon {
+class Sampler::PlatformData {
public:
// Get a handle to the calling thread. This is the thread that we are
// going to profile. We need to make a copy of the handle because we are
@@ -263,12 +325,11 @@ class Sampler::PlatformData : public PlatformDataCommon {
private:
HANDLE profiled_thread_;
};
-#endif
+#endif // USE_SIGNALS
#if defined(USE_SIGNALS)
-
-class SignalHandler : public AllStatic {
+class SignalHandler {
public:
static void SetUp() { if (!mutex_) mutex_ = new base::Mutex(); }
static void TearDown() { delete mutex_; mutex_ = NULL; }
@@ -284,13 +345,10 @@ class SignalHandler : public AllStatic {
}
static bool Installed() {
+ base::LockGuard<base::Mutex> lock_guard(mutex_);
return signal_handler_installed_;
}
-#if !V8_OS_NACL
- static void CollectSample(void* context, Sampler* sampler);
-#endif
-
private:
static void Install() {
#if !V8_OS_NACL
@@ -304,7 +362,7 @@ class SignalHandler : public AllStatic {
#endif
signal_handler_installed_ =
(sigaction(SIGPROF, &sa, &old_signal_handler_) == 0);
-#endif
+#endif // !V8_OS_NACL
}
static void Restore() {
@@ -317,6 +375,7 @@ class SignalHandler : public AllStatic {
}
#if !V8_OS_NACL
+ static void FillRegisterState(void* context, RegisterState* regs);
static void HandleProfilerSignal(int signal, siginfo_t* info, void* context);
#endif
// Protects the process wide state below.
@@ -335,26 +394,36 @@ bool SignalHandler::signal_handler_installed_ = false;
// As Native Client does not support signal handling, profiling is disabled.
#if !V8_OS_NACL
-void SignalHandler::CollectSample(void* context, Sampler* sampler) {
- if (sampler == NULL || (!sampler->IsProfiling() &&
- !sampler->IsRegistered())) {
- return;
- }
- Isolate* isolate = sampler->isolate();
+void SignalHandler::HandleProfilerSignal(int signal, siginfo_t* info,
+ void* context) {
+ USE(info);
+ if (signal != SIGPROF) return;
+ AtomicGuard atomic_guard(&SamplerManager::samplers_access_counter_, false);
+ if (!atomic_guard.is_success()) return;
+ pthread_t thread_id = pthread_self();
+ HashMap::Entry* entry =
+ SamplerManager::sampler_map_.Pointer()->Lookup(ThreadKey(thread_id),
+ ThreadHash(thread_id));
+ if (entry == NULL) return;
+ SamplerList* samplers = reinterpret_cast<SamplerList*>(entry->value);
- // We require a fully initialized and entered isolate.
- if (isolate == NULL || !isolate->IsInUse()) return;
+ v8::RegisterState state;
+ FillRegisterState(context, &state);
- if (v8::Locker::IsActive() &&
- !isolate->thread_manager()->IsLockedByCurrentThread()) {
- return;
- }
+ for (int i = 0; i < samplers->size(); ++i) {
+ Sampler* sampler = (*samplers)[i];
+ Isolate* isolate = sampler->isolate();
- v8::RegisterState state;
+ // We require a fully initialized and entered isolate.
+ if (isolate == NULL || !isolate->IsInUse()) return;
-#if defined(USE_SIMULATOR)
- if (!SimulatorHelper::FillRegisters(isolate, &state)) return;
-#else
+ if (v8::Locker::IsActive() && !Locker::IsLocked(isolate)) return;
+
+ sampler->SampleStack(state);
+ }
+}
+
+void SignalHandler::FillRegisterState(void* context, RegisterState* state) {
// Extracting the sample from the context is extremely machine dependent.
ucontext_t* ucontext = reinterpret_cast<ucontext_t*>(context);
#if !(V8_OS_OPENBSD || (V8_OS_LINUX && (V8_HOST_ARCH_PPC || V8_HOST_ARCH_S390)))
@@ -362,381 +431,187 @@ void SignalHandler::CollectSample(void* context, Sampler* sampler) {
#endif
#if V8_OS_LINUX
#if V8_HOST_ARCH_IA32
- state.pc = reinterpret_cast<Address>(mcontext.gregs[REG_EIP]);
- state.sp = reinterpret_cast<Address>(mcontext.gregs[REG_ESP]);
- state.fp = reinterpret_cast<Address>(mcontext.gregs[REG_EBP]);
+ state->pc = reinterpret_cast<void*>(mcontext.gregs[REG_EIP]);
+ state->sp = reinterpret_cast<void*>(mcontext.gregs[REG_ESP]);
+ state->fp = reinterpret_cast<void*>(mcontext.gregs[REG_EBP]);
#elif V8_HOST_ARCH_X64
- state.pc = reinterpret_cast<Address>(mcontext.gregs[REG_RIP]);
- state.sp = reinterpret_cast<Address>(mcontext.gregs[REG_RSP]);
- state.fp = reinterpret_cast<Address>(mcontext.gregs[REG_RBP]);
+ state->pc = reinterpret_cast<void*>(mcontext.gregs[REG_RIP]);
+ state->sp = reinterpret_cast<void*>(mcontext.gregs[REG_RSP]);
+ state->fp = reinterpret_cast<void*>(mcontext.gregs[REG_RBP]);
#elif V8_HOST_ARCH_ARM
#if V8_LIBC_GLIBC && !V8_GLIBC_PREREQ(2, 4)
// Old GLibc ARM versions used a gregs[] array to access the register
// values from mcontext_t.
- state.pc = reinterpret_cast<Address>(mcontext.gregs[R15]);
- state.sp = reinterpret_cast<Address>(mcontext.gregs[R13]);
- state.fp = reinterpret_cast<Address>(mcontext.gregs[R11]);
+ state->pc = reinterpret_cast<void*>(mcontext.gregs[R15]);
+ state->sp = reinterpret_cast<void*>(mcontext.gregs[R13]);
+ state->fp = reinterpret_cast<void*>(mcontext.gregs[R11]);
#else
- state.pc = reinterpret_cast<Address>(mcontext.arm_pc);
- state.sp = reinterpret_cast<Address>(mcontext.arm_sp);
- state.fp = reinterpret_cast<Address>(mcontext.arm_fp);
+ state->pc = reinterpret_cast<void*>(mcontext.arm_pc);
+ state->sp = reinterpret_cast<void*>(mcontext.arm_sp);
+ state->fp = reinterpret_cast<void*>(mcontext.arm_fp);
#endif // V8_LIBC_GLIBC && !V8_GLIBC_PREREQ(2, 4)
#elif V8_HOST_ARCH_ARM64
- state.pc = reinterpret_cast<Address>(mcontext.pc);
- state.sp = reinterpret_cast<Address>(mcontext.sp);
+ state->pc = reinterpret_cast<void*>(mcontext.pc);
+ state->sp = reinterpret_cast<void*>(mcontext.sp);
// FP is an alias for x29.
- state.fp = reinterpret_cast<Address>(mcontext.regs[29]);
+ state->fp = reinterpret_cast<void*>(mcontext.regs[29]);
#elif V8_HOST_ARCH_MIPS
- state.pc = reinterpret_cast<Address>(mcontext.pc);
- state.sp = reinterpret_cast<Address>(mcontext.gregs[29]);
- state.fp = reinterpret_cast<Address>(mcontext.gregs[30]);
+ state->pc = reinterpret_cast<void*>(mcontext.pc);
+ state->sp = reinterpret_cast<void*>(mcontext.gregs[29]);
+ state->fp = reinterpret_cast<void*>(mcontext.gregs[30]);
#elif V8_HOST_ARCH_MIPS64
- state.pc = reinterpret_cast<Address>(mcontext.pc);
- state.sp = reinterpret_cast<Address>(mcontext.gregs[29]);
- state.fp = reinterpret_cast<Address>(mcontext.gregs[30]);
+ state->pc = reinterpret_cast<void*>(mcontext.pc);
+ state->sp = reinterpret_cast<void*>(mcontext.gregs[29]);
+ state->fp = reinterpret_cast<void*>(mcontext.gregs[30]);
#elif V8_HOST_ARCH_PPC
- state.pc = reinterpret_cast<Address>(ucontext->uc_mcontext.regs->nip);
- state.sp = reinterpret_cast<Address>(ucontext->uc_mcontext.regs->gpr[PT_R1]);
- state.fp = reinterpret_cast<Address>(ucontext->uc_mcontext.regs->gpr[PT_R31]);
+ state->pc = reinterpret_cast<void*>(ucontext->uc_mcontext.regs->nip);
+ state->sp =
+ reinterpret_cast<void*>(ucontext->uc_mcontext.regs->gpr[PT_R1]);
+ state->fp =
+ reinterpret_cast<void*>(ucontext->uc_mcontext.regs->gpr[PT_R31]);
#elif V8_HOST_ARCH_S390
#if V8_TARGET_ARCH_32_BIT
// 31-bit target will have bit 0 (MSB) of the PSW set to denote addressing
// mode. This bit needs to be masked out to resolve actual address.
- state.pc =
- reinterpret_cast<Address>(ucontext->uc_mcontext.psw.addr & 0x7FFFFFFF);
+ state->pc =
+ reinterpret_cast<void*>(ucontext->uc_mcontext.psw.addr & 0x7FFFFFFF);
#else
- state.pc = reinterpret_cast<Address>(ucontext->uc_mcontext.psw.addr);
+ state->pc = reinterpret_cast<void*>(ucontext->uc_mcontext.psw.addr);
#endif // V8_TARGET_ARCH_32_BIT
- state.sp = reinterpret_cast<Address>(ucontext->uc_mcontext.gregs[15]);
- state.fp = reinterpret_cast<Address>(ucontext->uc_mcontext.gregs[11]);
+ state->sp = reinterpret_cast<void*>(ucontext->uc_mcontext.gregs[15]);
+ state->fp = reinterpret_cast<void*>(ucontext->uc_mcontext.gregs[11]);
#endif // V8_HOST_ARCH_*
#elif V8_OS_MACOSX
#if V8_HOST_ARCH_X64
#if __DARWIN_UNIX03
- state.pc = reinterpret_cast<Address>(mcontext->__ss.__rip);
- state.sp = reinterpret_cast<Address>(mcontext->__ss.__rsp);
- state.fp = reinterpret_cast<Address>(mcontext->__ss.__rbp);
+ state->pc = reinterpret_cast<void*>(mcontext->__ss.__rip);
+ state->sp = reinterpret_cast<void*>(mcontext->__ss.__rsp);
+ state->fp = reinterpret_cast<void*>(mcontext->__ss.__rbp);
#else // !__DARWIN_UNIX03
- state.pc = reinterpret_cast<Address>(mcontext->ss.rip);
- state.sp = reinterpret_cast<Address>(mcontext->ss.rsp);
- state.fp = reinterpret_cast<Address>(mcontext->ss.rbp);
+ state->pc = reinterpret_cast<void*>(mcontext->ss.rip);
+ state->sp = reinterpret_cast<void*>(mcontext->ss.rsp);
+ state->fp = reinterpret_cast<void*>(mcontext->ss.rbp);
#endif // __DARWIN_UNIX03
#elif V8_HOST_ARCH_IA32
#if __DARWIN_UNIX03
- state.pc = reinterpret_cast<Address>(mcontext->__ss.__eip);
- state.sp = reinterpret_cast<Address>(mcontext->__ss.__esp);
- state.fp = reinterpret_cast<Address>(mcontext->__ss.__ebp);
+ state->pc = reinterpret_cast<void*>(mcontext->__ss.__eip);
+ state->sp = reinterpret_cast<void*>(mcontext->__ss.__esp);
+ state->fp = reinterpret_cast<void*>(mcontext->__ss.__ebp);
#else // !__DARWIN_UNIX03
- state.pc = reinterpret_cast<Address>(mcontext->ss.eip);
- state.sp = reinterpret_cast<Address>(mcontext->ss.esp);
- state.fp = reinterpret_cast<Address>(mcontext->ss.ebp);
+ state->pc = reinterpret_cast<void*>(mcontext->ss.eip);
+ state->sp = reinterpret_cast<void*>(mcontext->ss.esp);
+ state->fp = reinterpret_cast<void*>(mcontext->ss.ebp);
#endif // __DARWIN_UNIX03
#endif // V8_HOST_ARCH_IA32
#elif V8_OS_FREEBSD
#if V8_HOST_ARCH_IA32
- state.pc = reinterpret_cast<Address>(mcontext.mc_eip);
- state.sp = reinterpret_cast<Address>(mcontext.mc_esp);
- state.fp = reinterpret_cast<Address>(mcontext.mc_ebp);
+ state->pc = reinterpret_cast<void*>(mcontext.mc_eip);
+ state->sp = reinterpret_cast<void*>(mcontext.mc_esp);
+ state->fp = reinterpret_cast<void*>(mcontext.mc_ebp);
#elif V8_HOST_ARCH_X64
- state.pc = reinterpret_cast<Address>(mcontext.mc_rip);
- state.sp = reinterpret_cast<Address>(mcontext.mc_rsp);
- state.fp = reinterpret_cast<Address>(mcontext.mc_rbp);
+ state->pc = reinterpret_cast<void*>(mcontext.mc_rip);
+ state->sp = reinterpret_cast<void*>(mcontext.mc_rsp);
+ state->fp = reinterpret_cast<void*>(mcontext.mc_rbp);
#elif V8_HOST_ARCH_ARM
- state.pc = reinterpret_cast<Address>(mcontext.mc_r15);
- state.sp = reinterpret_cast<Address>(mcontext.mc_r13);
- state.fp = reinterpret_cast<Address>(mcontext.mc_r11);
+ state->pc = reinterpret_cast<void*>(mcontext.mc_r15);
+ state->sp = reinterpret_cast<void*>(mcontext.mc_r13);
+ state->fp = reinterpret_cast<void*>(mcontext.mc_r11);
#endif // V8_HOST_ARCH_*
#elif V8_OS_NETBSD
#if V8_HOST_ARCH_IA32
- state.pc = reinterpret_cast<Address>(mcontext.__gregs[_REG_EIP]);
- state.sp = reinterpret_cast<Address>(mcontext.__gregs[_REG_ESP]);
- state.fp = reinterpret_cast<Address>(mcontext.__gregs[_REG_EBP]);
+ state->pc = reinterpret_cast<void*>(mcontext.__gregs[_REG_EIP]);
+ state->sp = reinterpret_cast<void*>(mcontext.__gregs[_REG_ESP]);
+ state->fp = reinterpret_cast<void*>(mcontext.__gregs[_REG_EBP]);
#elif V8_HOST_ARCH_X64
- state.pc = reinterpret_cast<Address>(mcontext.__gregs[_REG_RIP]);
- state.sp = reinterpret_cast<Address>(mcontext.__gregs[_REG_RSP]);
- state.fp = reinterpret_cast<Address>(mcontext.__gregs[_REG_RBP]);
+ state->pc = reinterpret_cast<void*>(mcontext.__gregs[_REG_RIP]);
+ state->sp = reinterpret_cast<void*>(mcontext.__gregs[_REG_RSP]);
+ state->fp = reinterpret_cast<void*>(mcontext.__gregs[_REG_RBP]);
#endif // V8_HOST_ARCH_*
#elif V8_OS_OPENBSD
#if V8_HOST_ARCH_IA32
- state.pc = reinterpret_cast<Address>(ucontext->sc_eip);
- state.sp = reinterpret_cast<Address>(ucontext->sc_esp);
- state.fp = reinterpret_cast<Address>(ucontext->sc_ebp);
+ state->pc = reinterpret_cast<void*>(ucontext->sc_eip);
+ state->sp = reinterpret_cast<void*>(ucontext->sc_esp);
+ state->fp = reinterpret_cast<void*>(ucontext->sc_ebp);
#elif V8_HOST_ARCH_X64
- state.pc = reinterpret_cast<Address>(ucontext->sc_rip);
- state.sp = reinterpret_cast<Address>(ucontext->sc_rsp);
- state.fp = reinterpret_cast<Address>(ucontext->sc_rbp);
+ state->pc = reinterpret_cast<void*>(ucontext->sc_rip);
+ state->sp = reinterpret_cast<void*>(ucontext->sc_rsp);
+ state->fp = reinterpret_cast<void*>(ucontext->sc_rbp);
#endif // V8_HOST_ARCH_*
#elif V8_OS_SOLARIS
- state.pc = reinterpret_cast<Address>(mcontext.gregs[REG_PC]);
- state.sp = reinterpret_cast<Address>(mcontext.gregs[REG_SP]);
- state.fp = reinterpret_cast<Address>(mcontext.gregs[REG_FP]);
+ state->pc = reinterpret_cast<void*>(mcontext.gregs[REG_PC]);
+ state->sp = reinterpret_cast<void*>(mcontext.gregs[REG_SP]);
+ state->fp = reinterpret_cast<void*>(mcontext.gregs[REG_FP]);
#elif V8_OS_QNX
#if V8_HOST_ARCH_IA32
- state.pc = reinterpret_cast<Address>(mcontext.cpu.eip);
- state.sp = reinterpret_cast<Address>(mcontext.cpu.esp);
- state.fp = reinterpret_cast<Address>(mcontext.cpu.ebp);
+ state->pc = reinterpret_cast<void*>(mcontext.cpu.eip);
+ state->sp = reinterpret_cast<void*>(mcontext.cpu.esp);
+ state->fp = reinterpret_cast<void*>(mcontext.cpu.ebp);
#elif V8_HOST_ARCH_ARM
- state.pc = reinterpret_cast<Address>(mcontext.cpu.gpr[ARM_REG_PC]);
- state.sp = reinterpret_cast<Address>(mcontext.cpu.gpr[ARM_REG_SP]);
- state.fp = reinterpret_cast<Address>(mcontext.cpu.gpr[ARM_REG_FP]);
+ state->pc = reinterpret_cast<void*>(mcontext.cpu.gpr[ARM_REG_PC]);
+ state->sp = reinterpret_cast<void*>(mcontext.cpu.gpr[ARM_REG_SP]);
+ state->fp = reinterpret_cast<void*>(mcontext.cpu.gpr[ARM_REG_FP]);
#endif // V8_HOST_ARCH_*
#elif V8_OS_AIX
- state.pc = reinterpret_cast<Address>(mcontext.jmp_context.iar);
- state.sp = reinterpret_cast<Address>(mcontext.jmp_context.gpr[1]);
- state.fp = reinterpret_cast<Address>(mcontext.jmp_context.gpr[31]);
+ state->pc = reinterpret_cast<void*>(mcontext.jmp_context.iar);
+ state->sp = reinterpret_cast<void*>(mcontext.jmp_context.gpr[1]);
+ state->fp = reinterpret_cast<void*>(mcontext.jmp_context.gpr[31]);
#endif // V8_OS_AIX
-#endif // USE_SIMULATOR
- sampler->SampleStack(state);
}
-#endif // V8_OS_NACL
-
-#endif // USE_SIGNALS
-
-
-class SamplerThread : public base::Thread {
- public:
- static const int kSamplerThreadStackSize = 64 * KB;
-
- explicit SamplerThread(int interval)
- : Thread(base::Thread::Options("SamplerThread", kSamplerThreadStackSize)),
- interval_(interval) {}
-
- static void SetUp() { if (!mutex_) mutex_ = new base::Mutex(); }
- static void TearDown() { delete mutex_; mutex_ = NULL; }
-
- static void AddActiveSampler(Sampler* sampler) {
- bool need_to_start = false;
- base::LockGuard<base::Mutex> lock_guard(mutex_);
- if (instance_ == NULL) {
- // Start a thread that will send SIGPROF signal to VM threads,
- // when CPU profiling will be enabled.
- instance_ = new SamplerThread(sampler->interval());
- need_to_start = true;
- }
-
- DCHECK(sampler->IsActive());
- DCHECK(instance_->interval_ == sampler->interval());
-
-#if defined(USE_SIGNALS)
- AddSampler(sampler);
-#else
- DCHECK(!instance_->active_samplers_.Contains(sampler));
- instance_->active_samplers_.Add(sampler);
-#endif // USE_SIGNALS
-
- if (need_to_start) instance_->StartSynchronously();
- }
-
- static void RemoveSampler(Sampler* sampler) {
- SamplerThread* instance_to_remove = NULL;
- {
- base::LockGuard<base::Mutex> lock_guard(mutex_);
-
- DCHECK(sampler->IsActive() || sampler->IsRegistered());
-#if defined(USE_SIGNALS)
- {
- AtomicGuard atomic_guard(&sampler_list_access_counter_);
- // Remove sampler from map.
- pthread_t thread_id = sampler->platform_data()->vm_tid();
- void* thread_key = ThreadKey(thread_id);
- uint32_t thread_hash = ThreadHash(thread_id);
- HashMap::Entry* entry =
- thread_id_to_samplers_.Get().Lookup(thread_key, thread_hash);
- DCHECK(entry != NULL);
- SamplerList* samplers = reinterpret_cast<SamplerList*>(entry->value);
- samplers->RemoveElement(sampler);
- if (samplers->is_empty()) {
- thread_id_to_samplers_.Pointer()->Remove(thread_key, thread_hash);
- delete samplers;
- }
- if (thread_id_to_samplers_.Get().occupancy() == 0) {
- instance_to_remove = instance_;
- instance_ = NULL;
- }
- }
-#else
- bool removed = instance_->active_samplers_.RemoveElement(sampler);
- DCHECK(removed);
- USE(removed);
-
- // We cannot delete the instance immediately as we need to Join() the
- // thread but we are holding mutex_ and the thread may try to acquire it.
- if (instance_->active_samplers_.is_empty()) {
- instance_to_remove = instance_;
- instance_ = NULL;
- }
-#endif // USE_SIGNALS
- }
- if (!instance_to_remove) return;
- instance_to_remove->Join();
- delete instance_to_remove;
- }
-
- // Unlike AddActiveSampler, this method only adds a sampler,
- // but won't start the sampler thread.
- static void RegisterSampler(Sampler* sampler) {
- base::LockGuard<base::Mutex> lock_guard(mutex_);
-#if defined(USE_SIGNALS)
- AddSampler(sampler);
-#endif // USE_SIGNALS
- }
-
- // Implement Thread::Run().
- virtual void Run() {
- while (true) {
- {
- base::LockGuard<base::Mutex> lock_guard(mutex_);
-#if defined(USE_SIGNALS)
- if (thread_id_to_samplers_.Get().occupancy() == 0) break;
- if (SignalHandler::Installed()) {
- for (HashMap::Entry *p = thread_id_to_samplers_.Get().Start();
- p != NULL; p = thread_id_to_samplers_.Get().Next(p)) {
-#if V8_OS_AIX && V8_TARGET_ARCH_PPC64
- // on AIX64, cannot cast (void *) to pthread_t which is
- // of type unsigned int (4bytes)
- pthread_t thread_id = reinterpret_cast<intptr_t>(p->key);
-#else
- pthread_t thread_id = reinterpret_cast<pthread_t>(p->key);
-#endif
- pthread_kill(thread_id, SIGPROF);
- }
- }
-#else
- if (active_samplers_.is_empty()) break;
- // When CPU profiling is enabled both JavaScript and C++ code is
- // profiled. We must not suspend.
- for (int i = 0; i < active_samplers_.length(); ++i) {
- Sampler* sampler = active_samplers_.at(i);
- if (!sampler->IsProfiling()) continue;
- sampler->DoSample();
- }
-#endif // USE_SIGNALS
- }
- base::OS::Sleep(base::TimeDelta::FromMilliseconds(interval_));
- }
- }
-
- private:
- // Protects the process wide state below.
- static base::Mutex* mutex_;
- static SamplerThread* instance_;
-
- const int interval_;
+#endif // !V8_OS_NACL
-#if defined(USE_SIGNALS)
- struct HashMapCreateTrait {
- static void Construct(HashMap* allocated_ptr) {
- new (allocated_ptr) HashMap(HashMap::PointersMatch);
- }
- };
- friend class SignalHandler;
- static base::LazyInstance<HashMap, HashMapCreateTrait>::type
- thread_id_to_samplers_;
- static base::AtomicValue<int> sampler_list_access_counter_;
- static void AddSampler(Sampler* sampler) {
- AtomicGuard atomic_guard(&sampler_list_access_counter_);
- // Add sampler into map if needed.
- pthread_t thread_id = sampler->platform_data()->vm_tid();
- HashMap::Entry *entry =
- thread_id_to_samplers_.Pointer()->LookupOrInsert(ThreadKey(thread_id),
- ThreadHash(thread_id));
- if (entry->value == NULL) {
- SamplerList* samplers = new SamplerList();
- samplers->Add(sampler);
- entry->value = samplers;
- } else {
- SamplerList* samplers = reinterpret_cast<SamplerList*>(entry->value);
- if (!samplers->Contains(sampler)) {
- samplers->Add(sampler);
- }
- }
- }
-#else
- SamplerList active_samplers_;
#endif // USE_SIGNALS
- DISALLOW_COPY_AND_ASSIGN(SamplerThread);
-};
-
-
-base::Mutex* SamplerThread::mutex_ = NULL;
-SamplerThread* SamplerThread::instance_ = NULL;
-#if defined(USE_SIGNALS)
-base::LazyInstance<HashMap, SamplerThread::HashMapCreateTrait>::type
- SamplerThread::thread_id_to_samplers_ = LAZY_INSTANCE_INITIALIZER;
-base::AtomicValue<int> SamplerThread::sampler_list_access_counter_(0);
-
-// As Native Client does not support signal handling, profiling is disabled.
-#if !V8_OS_NACL
-void SignalHandler::HandleProfilerSignal(int signal, siginfo_t* info,
- void* context) {
- USE(info);
- if (signal != SIGPROF) return;
- AtomicGuard atomic_guard(&SamplerThread::sampler_list_access_counter_, false);
- if (!atomic_guard.is_success()) return;
- pthread_t thread_id = pthread_self();
- HashMap::Entry* entry =
- SamplerThread::thread_id_to_samplers_.Pointer()->Lookup(
- ThreadKey(thread_id), ThreadHash(thread_id));
- if (entry == NULL)
- return;
- SamplerList* samplers = reinterpret_cast<SamplerList*>(entry->value);
- for (int i = 0; i < samplers->length(); ++i) {
- Sampler* sampler = samplers->at(i);
- CollectSample(context, sampler);
- }
-}
-#endif // !V8_OS_NACL
-#endif // USE_SIGNALs
-
void Sampler::SetUp() {
#if defined(USE_SIGNALS)
SignalHandler::SetUp();
#endif
- SamplerThread::SetUp();
}
void Sampler::TearDown() {
- SamplerThread::TearDown();
#if defined(USE_SIGNALS)
SignalHandler::TearDown();
#endif
}
-Sampler::Sampler(Isolate* isolate, int interval)
- : isolate_(isolate),
- interval_(interval),
+Sampler::Sampler(Isolate* isolate)
+ : is_counting_samples_(false),
+ js_sample_count_(0),
+ external_sample_count_(0),
+ isolate_(isolate),
profiling_(false),
has_processing_thread_(false),
active_(false),
- registered_(false),
- is_counting_samples_(false),
- js_sample_count_(0),
- external_sample_count_(0) {
+ registered_(false) {
data_ = new PlatformData;
}
Sampler::~Sampler() {
DCHECK(!IsActive());
+#if defined(USE_SIGNALS)
if (IsRegistered()) {
- SamplerThread::RemoveSampler(this);
+ SamplerManager::RemoveSampler(this);
}
+#endif
delete data_;
}
void Sampler::Start() {
DCHECK(!IsActive());
SetActive(true);
- SamplerThread::AddActiveSampler(this);
+#if defined(USE_SIGNALS)
+ SamplerManager::AddSampler(this);
+#endif
}
void Sampler::Stop() {
+#if defined(USE_SIGNALS)
+ SamplerManager::RemoveSampler(this);
+#endif
DCHECK(IsActive());
- SamplerThread::RemoveSampler(this);
SetActive(false);
SetRegistered(false);
}
@@ -758,28 +633,12 @@ void Sampler::DecreaseProfilingDepth() {
}
-void Sampler::SampleStack(const v8::RegisterState& state) {
- TickSample* sample = isolate_->cpu_profiler()->StartTickSample();
- TickSample sample_obj;
- if (sample == NULL) sample = &sample_obj;
- sample->Init(isolate_, state, TickSample::kIncludeCEntryFrame, true);
- if (is_counting_samples_ && !sample->timestamp.IsNull()) {
- if (sample->state == JS) ++js_sample_count_;
- if (sample->state == EXTERNAL) ++external_sample_count_;
- }
- Tick(sample);
- if (sample != &sample_obj) {
- isolate_->cpu_profiler()->FinishTickSample();
- }
-}
-
-
#if defined(USE_SIGNALS)
void Sampler::DoSample() {
if (!SignalHandler::Installed()) return;
if (!IsActive() && !IsRegistered()) {
- SamplerThread::RegisterSampler(this);
+ SamplerManager::AddSampler(this);
SetRegistered(true);
}
pthread_kill(platform_data()->vm_tid(), SIGPROF);
@@ -800,22 +659,15 @@ void Sampler::DoSample() {
context.ContextFlags = CONTEXT_FULL;
if (GetThreadContext(profiled_thread, &context) != 0) {
v8::RegisterState state;
-#if defined(USE_SIMULATOR)
- if (!SimulatorHelper::FillRegisters(isolate(), &state)) {
- ResumeThread(profiled_thread);
- return;
- }
-#else
#if V8_HOST_ARCH_X64
- state.pc = reinterpret_cast<Address>(context.Rip);
- state.sp = reinterpret_cast<Address>(context.Rsp);
- state.fp = reinterpret_cast<Address>(context.Rbp);
+ state.pc = reinterpret_cast<void*>(context.Rip);
+ state.sp = reinterpret_cast<void*>(context.Rsp);
+ state.fp = reinterpret_cast<void*>(context.Rbp);
#else
- state.pc = reinterpret_cast<Address>(context.Eip);
- state.sp = reinterpret_cast<Address>(context.Esp);
- state.fp = reinterpret_cast<Address>(context.Ebp);
+ state.pc = reinterpret_cast<void*>(context.Eip);
+ state.sp = reinterpret_cast<void*>(context.Esp);
+ state.fp = reinterpret_cast<void*>(context.Ebp);
#endif
-#endif // USE_SIMULATOR
SampleStack(state);
}
ResumeThread(profiled_thread);
@@ -823,6 +675,5 @@ void Sampler::DoSample() {
#endif // USE_SIGNALS
-
-} // namespace internal
+} // namespace sampler
} // namespace v8
« no previous file with comments | « src/libsampler/v8-sampler.h ('k') | src/log.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698