Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1922243002: Add a test for iframe srcdoc origin. (Closed)

Created:
4 years, 8 months ago by nasko
Modified:
4 years, 7 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a test for iframe srcdoc origin. This CL adds a test to ensure that iframes with srcdoc are properly navigated to the origin of the parent. BUG=591509, 585649 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/faa01fb5cdfe41211cbe25154445d50dd774d97e Cr-Commit-Position: refs/heads/master@{#390826}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -0 lines) Patch
M content/browser/frame_host/frame_tree_browsertest.cc View 1 chunk +62 lines, -0 lines 1 comment Download

Messages

Total messages: 11 (6 generated)
nasko
Hey Nick, While I get to split the other CL, here is another one to ...
4 years, 7 months ago (2016-04-29 19:39:07 UTC) #3
ncarter (slow)
lgtm https://codereview.chromium.org/1922243002/diff/1/content/browser/frame_host/frame_tree_browsertest.cc File content/browser/frame_host/frame_tree_browsertest.cc (right): https://codereview.chromium.org/1922243002/diff/1/content/browser/frame_host/frame_tree_browsertest.cc#newcode512 content/browser/frame_host/frame_tree_browsertest.cc:512: } srcdoc is very entertaining. I just checked ...
4 years, 7 months ago (2016-04-29 20:10:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922243002/1
4 years, 7 months ago (2016-04-30 00:15:33 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-30 01:04:28 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:30:43 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/faa01fb5cdfe41211cbe25154445d50dd774d97e
Cr-Commit-Position: refs/heads/master@{#390826}

Powered by Google App Engine
This is Rietveld 408576698