tracing/tracing/ui/base/chart_base.html - Issue 1922193002: [polymer] Replaces this.appendChild with Polymer.dom(this).appendChild

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/base/chart_base.html

Issue 1922193002: [polymer] Replaces this.appendChild with Polymer.dom(this).appendChild (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/ui/analysis/single_object_snapshot_sub_view.html ('k') | tracing/tracing/ui/base/list_and_associated_view.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/ui/base/chart_base.html

diff --git a/tracing/tracing/ui/base/chart_base.html b/tracing/tracing/ui/base/chart_base.html

index 5155376058a907ef90e88adbe8c869844b6ee941..b22ba2e65e6fc0da94f3c5a59c7bd915ec1152cf 100644

--- a/tracing/tracing/ui/base/chart_base.html

+++ b/tracing/tracing/ui/base/chart_base.html

@@ -78,7 +78,7 @@ tr.exportTo('tr.ui.b', function() {

var template = THIS_DOC.querySelector('#chart-base-template');

var svgEl = template.content.querySelector('svg');

for (var i = 0; i < svgEl.children.length; i++)

- this.appendChild(svgEl.children[i].cloneNode(true));

+ Polymer.dom(this).appendChild(svgEl.children[i].cloneNode(true));

// svg likes to take over width & height properties for some reason. This

// works around it.