tracing/tracing/ui/analysis/analysis_view.html - Issue 1922193002: [polymer] Replaces this.appendChild with Polymer.dom(this).appendChild

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/analysis/analysis_view.html

Issue 1922193002: [polymer] Replaces this.appendChild with Polymer.dom(this).appendChild (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/base/unittest/interactive_test_runner.html ('k') | tracing/tracing/ui/analysis/multi_frame_sub_view.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/ui/analysis/analysis_view.html

diff --git a/tracing/tracing/ui/analysis/analysis_view.html b/tracing/tracing/ui/analysis/analysis_view.html

index f332bd9b8f13c87f551b123029420c818f373e3b..b0db24cf0b5a3979762dd4573496acef8dfa3772 100644

--- a/tracing/tracing/ui/analysis/analysis_view.html

+++ b/tracing/tracing/ui/analysis/analysis_view.html

@@ -86,7 +86,7 @@ using custom elements specialized for different event types.

ready: function() {

this.tabView_ = document.createElement('tr-ui-a-tab-view');

this.tabView_.style.flex = '1 1 auto';

- this.appendChild(this.tabView_);

+ Polymer.dom(this).appendChild(this.tabView_);

this.brushingStateController_ = undefined;

this.onSelectedTabChange_ = this.onSelectedTabChange_.bind(this);

this.onSelectionChanged_ = this.onSelectionChanged_.bind(this);