Issue 1922173003: Adds LoadClassIdInstr to DBC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1922173003: Adds LoadClassIdInstr to DBC (Closed)

Created:
4 years, 8 months ago by zra

Modified:
4 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Google), Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -12 lines)			Patch
M	runtime/vm/constants_dbc.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_dbc.cc	View	2 chunks	+18 lines, -9 lines	0 comments	Download
M	runtime/vm/simulator_dbc.cc	View	1 chunk	+15 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

Vyacheslav Egorov (Google)

LGTM though I don't like that we have two bytecode instructions, but I see no ...

4 years, 7 months ago (2016-05-02 09:02:55 UTC) #4

zra

4 years, 7 months ago (2016-05-02 16:02:26 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5d7ecb85000b7c683e6d631ae3bae8cd2214ed03.