Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: tools/testing/dart/runtime_configuration.dart

Issue 1922163002: Initial support to test.dart for running precompiler tests on android devices (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Some fixes Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/runtime_configuration.dart
diff --git a/tools/testing/dart/runtime_configuration.dart b/tools/testing/dart/runtime_configuration.dart
index 71913427ccdc30dd2f90a7c9dc897087a4aae1b5..213a07c44757ffa59cc20e98c0fdf7de4ae644ee 100644
--- a/tools/testing/dart/runtime_configuration.dart
+++ b/tools/testing/dart/runtime_configuration.dart
@@ -54,6 +54,9 @@ class RuntimeConfiguration {
return new DartProductRuntimeConfiguration();
case 'dart_precompiled':
+ if (configuration['system'] == 'android') {
+ return new DartPrecompiledAdbRuntimeConfiguration(useBlobs: useBlobs);
+ }
return new DartPrecompiledRuntimeConfiguration(useBlobs: useBlobs);
case 'drt':
@@ -275,6 +278,32 @@ class DartPrecompiledRuntimeConfiguration extends DartVmRuntimeConfiguration {
}
}
+class DartPrecompiledAdbRuntimeConfiguration
+ extends DartVmRuntimeConfiguration {
+ final bool useBlobs;
+ DartPrecompiledAdbRuntimeConfiguration({bool useBlobs}) : useBlobs = useBlobs;
+
+ List<Command> computeRuntimeCommands(
+ TestSuite suite,
+ CommandBuilder commandBuilder,
+ CommandArtifact artifact,
+ List<String> arguments,
+ Map<String, String> environmentOverrides) {
+ String script = artifact.filename;
+ String type = artifact.mimeType;
+ if (script != null && type != 'application/dart-precompiled') {
+ throw "dart_precompiled cannot run files of type '$type'.";
+ }
+
+ String precompiledRunner = suite.dartPrecompiledBinaryFileName;
+ return <Command>[
+ commandBuilder.getAdbPrecompiledCommand(precompiledRunner,
+ artifact.filename,
Bill Hesse 2016/04/27 12:22:32 script is a local == artifact.filename.
kustermann 2016/04/27 13:25:09 Done. Strictly speaking it's not even a filename
+ useBlobs)
+ ];
+ }
+}
+
/// Temporary runtime configuration for browser runtimes that haven't been
/// migrated yet.
// TODO(ahe): Remove this class.

Powered by Google App Engine
This is Rietveld 408576698