Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Unified Diff: tools/testing/dart/compiler_configuration.dart

Issue 1922163002: Initial support to test.dart for running precompiler tests on android devices (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/compiler_configuration.dart
diff --git a/tools/testing/dart/compiler_configuration.dart b/tools/testing/dart/compiler_configuration.dart
index 161252a17841a0569f90098f660039ae6d641b04..7fcf990ca5a88e526553618c57990e7bdb3cd5fc 100644
--- a/tools/testing/dart/compiler_configuration.dart
+++ b/tools/testing/dart/compiler_configuration.dart
@@ -374,11 +374,15 @@ class PrecompilerCompilerConfiguration extends CompilerConfiguration {
cc_flags = "-m64";
} else if (arch == 'simarm64') {
cc_flags = "-m64";
+ } else if (arch == 'ia32') {
+ cc_flags = "-m32";
} else if (arch == 'simarm') {
cc_flags = "-m32";
} else if (arch == 'simmips') {
cc_flags = "-m32";
} else if (arch == 'arm') {
+ // TODO: If we're not using "--use_blobs" we need to use the arm cross
+ // compiler instead of just 'gcc'.
cc_flags = "";
} else if (arch == 'mips') {
cc_flags = "-EL";
@@ -387,13 +391,13 @@ class PrecompilerCompilerConfiguration extends CompilerConfiguration {
}
var exec = cc;
- var args = [
- shared,
- cc_flags,
+ var args = [ shared ];
+ if (cc_flags != null && cc_flags.length > 0) args.add(cc_flags);
+ args.addAll([
'-o',
'$tempDir/$libname',
'$tempDir/precompiled.S'
- ];
+ ]);
return commandBuilder.getCompilationCommand('assemble', tempDir, !useSdk,
bootstrapDependencies(buildDir), exec, args, environmentOverrides);

Powered by Google App Engine
This is Rietveld 408576698