Initial support to test.dart for running precompiler tests on android devices

tools/testing/dart/test_configurations.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test_configurations;
 
 import "dart:async";
 import 'dart:io';
 import "dart:math" as math;
 
+import 'android.dart';
 import "browser_controller.dart";
 import "co19_test_config.dart";
 import "http_server.dart";
 import "path.dart";
 import "test_progress.dart";
 import "test_runner.dart";
 import "test_suite.dart";
 import "utils.dart";
 import "vm_test_config.dart";
 
@@ skipping 21 matching lines @@
   new Path('tests/isolate'),
   new Path('tests/language'),
   new Path('tests/lib'),
   new Path('tests/standalone'),
   new Path('tests/try'),
   new Path('tests/utils'),
   new Path('utils/tests/css'),
   new Path('utils/tests/peg'),
 ];
 
-void testConfigurations(List<Map> configurations) {
+Future testConfigurations(List<Map> configurations) async {
   var startTime = new DateTime.now();
   // Extract global options from first configuration.
   var firstConf = configurations[0];
   var maxProcesses = firstConf['tasks'];
   var progressIndicator = firstConf['progress'];
   // TODO(kustermann): Remove this option once the buildbots don't use it
   // anymore.
   var failureSummary = firstConf['failure-summary'];
   BuildbotProgressIndicator.stepName = firstConf['step_name'];
   var verbose = firstConf['verbose'];
@@ skipping 211 matching lines @@
   }
 
   // The only progress indicator when listing tests should be the
   // the summary printer.
   if (listTests) {
     eventListener.add(new SummaryPrinter(jsonOnly: reportInJson));
   } else {
     eventListener.add(new ExitCodeSetter());
   }
 
-  void startProcessQueue() {
+  Future startProcessQueue() async {
+    AdbDevicePool pool;
+
+    bool needsAdbDevicePool = configurations.any((Map conf) {
+      return conf['runtime'] == 'dart_precompiled' &&
+             conf['system'] == 'android';
+    });
+    if (needsAdbDevicePool) {
+      pool = await AdbDevicePool.create();
+    }

[Bill Hesse, 2016/04/27 12:22:32]

We have code for awaiting the AdbDevices in browser_controller.dart:

      var idbNames = await AdbHelper.listDevices();
      idleAdbDevices = new List.from(idbNames.map((id) => new AdbDevice(id)));

That should perhaps use your pool, or maybe the pool could be moved down to a
lower level than ProcessQueue, and initialized later.

If it has to be up at this level, we could wait for it before the
startProcessQueue function, down where we wait for serverFutures, and they all
could be awaits.

[kustermann, 2016/04/27 13:25:09]

I'd really prefer not to modify any unrelated code (especially in browser
controller) to avoid breaking anything.

There's dead code in browser controller, code that doesn't work, and code that I
might not be able to test locally. So I rather not touch it.

I also don't like it much and unfortunately all the work is done in the
constructor. Refactoring this / cleaning this up should not be part of this CL.

+
     // [firstConf] is needed here, since the ProcessQueue needs to know the
     // settings of 'noBatch' and 'local_ip'
     new ProcessQueue(
         firstConf,
         maxProcesses,
         maxBrowserProcesses,
         startTime,
         testSuites,
         eventListener,
         allTestsFinished,
         verbose,
         recordingPath,
-        recordingOutputPath);
+        recordingOutputPath,
+        pool);
   }
 
   // Start all the HTTP servers required before starting the process queue.
   if (serverFutures.isEmpty) {
-    startProcessQueue();
+    await startProcessQueue();
   } else {
-    Future.wait(serverFutures).then((_) => startProcessQueue());
+    await Future.wait(serverFutures).then((_) => startProcessQueue());

[Bill Hesse, 2016/04/27 12:22:32]

This should just be:

if (serverFutures.isNotEmpty) {
  await Future.wait(serverFutures);
}
await startProcessQueue();

Or:
var pool = await AdbDevicePoolIfNeeded;
startProcessQueue(pool);

   }
 }