Initial support to test.dart for running precompiler tests on android devices

tools/testing/dart/compiler_configuration.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library compiler_configuration;
 
 import 'dart:io' show Platform;
 
 import 'runtime_configuration.dart' show RuntimeConfiguration;
 
@@ skipping 328 matching lines @@
       CommandBuilder commandBuilder,
       List arguments,
       Map<String, String> environmentOverrides) {
     var exec = "$buildDir/dart_bootstrap";
     var args = new List();
     args.add("--gen-precompiled-snapshot=$tempDir");
     if (useBlobs) {
       args.add("--use_blobs");
     }
     args.addAll(arguments);
+    if (arch == 'arm') {
+      args.add('--no-sim-use-hardfp');

[Bill Hesse, 2016/04/27 12:22:32]

I think this should be before the arguments parameter is added.  If the input
file is last, it should remain last.

[kustermann, 2016/04/27 13:25:09]

It is in the latest patchset.

+    }
 
     return commandBuilder.getCompilationCommand('precompiler', tempDir, !useSdk,
         bootstrapDependencies(buildDir), exec, args, environmentOverrides);
   }
 
   CompilationCommand computeAssembleCommand(
       String tempDir,
       String buildDir,
       CommandBuilder commandBuilder,
       List arguments,
       Map<String, String> environmentOverrides) {
     var cc, cc_flags, shared, libname;
     if (Platform.isLinux) {
       cc = 'gcc';
       shared = '-shared';
       libname = 'libprecompiled.so';
     } else if (Platform.isMacOS) {
       cc = 'clang';
       shared = '-dynamiclib';
       libname = 'libprecompiled.dylib';
     } else {
       throw "Platform not supported: ${Platform.operatingSystem}";
     }
 
     if (arch == 'x64') {
       cc_flags = "-m64";
     } else if (arch == 'simarm64') {
       cc_flags = "-m64";
+    } else if (arch == 'ia32') {
+      cc_flags = "-m32";
     } else if (arch == 'simarm') {
       cc_flags = "-m32";
     } else if (arch == 'simmips') {
       cc_flags = "-m32";
     } else if (arch == 'arm') {
+      // TODO: If we're not using "--use_blobs" we need to use the arm cross
+      // compiler instead of just 'gcc'.
       cc_flags = "";

[Bill Hesse, 2016/04/27 12:22:32]

Maybe use null here instead.  Or find out the correct -m flag to use, if there
is one.

[kustermann, 2016/04/27 13:25:09]

Done.

     } else if (arch == 'mips') {
       cc_flags = "-EL";
     } else {
       throw "Architecture not supported: $arch";
     }
 
     var exec = cc;
-    var args = [
-      shared,
-      cc_flags,
+    var args = [ shared ];
+    if (cc_flags != null && cc_flags.length > 0) args.add(cc_flags);

[Bill Hesse, 2016/04/27 12:22:31]

Decide which value to use for "none" in arch == 'arm' case, and only check that.

[kustermann, 2016/04/27 13:25:09]

Done.

+    args.addAll([
       '-o',
       '$tempDir/$libname',
       '$tempDir/precompiled.S'
-    ];
+    ]);
 
     return commandBuilder.getCompilationCommand('assemble', tempDir, !useSdk,
         bootstrapDependencies(buildDir), exec, args, environmentOverrides);
   }
 
   // This step reduces the amount of space needed to run the precompilation
   // tests by 60%.
   CompilationCommand computeRemoveAssemblyCommand(
       String tempDir,
       String buildDir,
@@ skipping 191 matching lines @@
       RuntimeConfiguration runtimeConfiguration,
       String buildDir,
       TestInformation info,
       List<String> vmOptions,
       List<String> sharedOptions,
       List<String> originalArguments,
       CommandArtifact artifact) {
     return <String>[];
   }
 }