Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1922153004: Update font_service to understand 'oblique'. (Closed)

Created:
4 years, 7 months ago by bungeman-chromium
Modified:
4 years, 7 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update font_service to understand 'oblique'. Skia is adding 'oblique' to SkFontStyle::Slant to handle font families with both italic and oblique faces. This allows the font_service to forward this value. BUG=chromium:607259 Committed: https://crrev.com/2ad9fb9ca0cd95da8fe4701f19fae02311b9a2c8 Cr-Commit-Position: refs/heads/master@{#390189}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M components/font_service/font_service_app.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M components/font_service/public/interfaces/font_service.mojom View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
bungeman-chromium
This depends on https://crrev.com/1921903002/ rolling into chromium first, but it has been tested with https://crrev.com/1921503006/ ...
4 years, 7 months ago (2016-04-27 17:46:25 UTC) #2
Elliot Glaysher
lgtm
4 years, 7 months ago (2016-04-27 17:49:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922153004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922153004/1
4 years, 7 months ago (2016-04-27 20:35:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 21:19:01 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:13:14 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ad9fb9ca0cd95da8fe4701f19fae02311b9a2c8
Cr-Commit-Position: refs/heads/master@{#390189}

Powered by Google App Engine
This is Rietveld 408576698