Disabled ARC for ephemeral users.

Disabled ARC for ephemeral users.

And users which data is ephemeral (guests, demo, public etc.)

TEST: new added ArcAuthServiceTest.DisabledForEphemeralDataUsers

BUG= b/26402681

Committed: https://crrev.com/79e934428a296d5b279c8da97aac3dfd1575af07
Cr-Commit-Position: refs/heads/master@{#390598}

[Roman Sorokin (ftl), 2016-04-26 14:24:44]

The CQ bit was checked by rsorokin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-26 14:24:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1922143002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1922143002/1

[Roman Sorokin (ftl), 2016-04-26 14:25:10]

Description was changed from

==========
Disabled ARC++ for ephemeral users.

And users which data is ephemeral (guests, demo, public etc.)

TEST: new added ArcAuthServiceTest.DisabledForEphemeralDataUsers

BUG= b/26402681
==========

to

==========
Disabled ARC++ for ephemeral users.

And users which data is ephemeral (guests, demo, public etc.)

TEST: new added ArcAuthServiceTest.DisabledForEphemeralDataUsers

BUG= b/26402681
==========

[Roman Sorokin (ftl), 2016-04-26 14:25:10]

rsorokin@chromium.org changed reviewers:
+ bartfab@chromium.org

[commit-bot: I haz the power, 2016-04-26 14:26:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 14:26:57]

Dry run: Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Roman Sorokin (ftl), 2016-04-26 14:27:53]

Description was changed from

==========
Disabled ARC++ for ephemeral users.

And users which data is ephemeral (guests, demo, public etc.)

TEST: new added ArcAuthServiceTest.DisabledForEphemeralDataUsers

BUG= b/26402681
==========

to

==========
Disabled ARC for ephemeral users.

And users which data is ephemeral (guests, demo, public etc.)

TEST: new added ArcAuthServiceTest.DisabledForEphemeralDataUsers

BUG= b/26402681
==========

[Roman Sorokin (ftl), 2016-04-26 14:29:19]

rsorokin@chromium.org changed reviewers:
+ alemate@chromium.org

[Roman Sorokin (ftl), 2016-04-26 15:05:02]

The CQ bit was checked by rsorokin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-26 15:05:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1922143002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1922143002/20001

[commit-bot: I haz the power, 2016-04-26 16:13:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 16:13:52]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Roman Sorokin (ftl), 2016-04-27 12:55:30]

The CQ bit was checked by rsorokin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 12:55:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1922143002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1922143002/40001

[Roman Sorokin (ftl), 2016-04-27 13:18:52]

Please take a look.

[commit-bot: I haz the power, 2016-04-27 14:11:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 14:11:39]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Roman Sorokin (ftl), 2016-04-27 15:41:41]

The CQ bit was checked by rsorokin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 15:42:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1922143002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1922143002/60001

[commit-bot: I haz the power, 2016-04-27 16:28:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 16:28:54]

Dry run: This issue passed the CQ dry run.

[Alexander Alekseev, 2016-04-27 21:11:18]

lgtm with nits

https://codereview.chromium.org/1922143002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc (right):

https://codereview.chromium.org/1922143002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc:141:
account_id.GetUserEmail()));
nit: active_user_ = nullptr ?

[Roman Sorokin (ftl), 2016-04-28 11:31:37]

rsorokin@chromium.org changed reviewers:
+ peletskyi@chromium.org

[Roman Sorokin (ftl), 2016-04-28 11:31:38]

Sasha, please take a look.

[peletskyi, 2016-04-28 12:00:41]

On 2016/04/28 11:31:38, Roman Sorokin wrote:
> Sasha, please take a look.

lgtm :)

[peletskyi, 2016-04-28 12:00:55]

https://codereview.chromium.org/1922143002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_auth_service_unittest.cc (right):

https://codereview.chromium.org/1922143002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_auth_service_unittest.cc:136: PrefService* prefs
= profile()->GetPrefs();
nit: PrefService* const

https://codereview.chromium.org/1922143002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_auth_service_unittest.cc:140:
chromeos::FakeChromeUserManager* fake_user_manager = GetFakeUserManager();
FakeChromeUserManager* const

https://codereview.chromium.org/1922143002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc (right):

https://codereview.chromium.org/1922143002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc:143: for
(user_manager::User* user : users_) {
nit: User* const

[Roman Sorokin (ftl), 2016-04-28 13:27:59]

https://codereview.chromium.org/1922143002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_auth_service_unittest.cc (right):

https://codereview.chromium.org/1922143002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_auth_service_unittest.cc:136: PrefService* prefs
= profile()->GetPrefs();
On 2016/04/28 12:00:55, peletskyi wrote:
> nit: PrefService* const

Done.

https://codereview.chromium.org/1922143002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_auth_service_unittest.cc:140:
chromeos::FakeChromeUserManager* fake_user_manager = GetFakeUserManager();
On 2016/04/28 12:00:55, peletskyi wrote:
> FakeChromeUserManager* const

Done.

https://codereview.chromium.org/1922143002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc (right):

https://codereview.chromium.org/1922143002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc:141:
account_id.GetUserEmail()));
On 2016/04/27 21:11:18, Alexander Alekseev wrote:
> nit: active_user_ = nullptr ?

Done.

[Roman Sorokin (ftl), 2016-04-28 13:36:33]

rsorokin@chromium.org changed reviewers:
+ xiyuan@chromium.org

[Roman Sorokin (ftl), 2016-04-28 13:36:34]

Hi Xiyuan,

Please review
chrome/browser/chromeos/arc/*
chrome/browser/ui/webui/options/browser_options_handler.cc

[Roman Sorokin (ftl), 2016-04-28 13:37:36]

Sasha, thanks for the fast review!

[xiyuan, 2016-04-28 16:06:22]

lgtm

[Roman Sorokin (ftl), 2016-04-29 06:58:11]

The CQ bit was checked by rsorokin@chromium.org

[Roman Sorokin (ftl), 2016-04-29 06:58:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
alemate@chromium.org, peletskyi@chromium.org
Link to the patchset: https://codereview.chromium.org/1922143002/#ps80001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-04-29 06:58:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1922143002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1922143002/80001

[commit-bot: I haz the power, 2016-04-29 07:54:25]

Description was changed from

==========
Disabled ARC for ephemeral users.

And users which data is ephemeral (guests, demo, public etc.)

TEST: new added ArcAuthServiceTest.DisabledForEphemeralDataUsers

BUG= b/26402681
==========

to

==========
Disabled ARC for ephemeral users.

And users which data is ephemeral (guests, demo, public etc.)

TEST: new added ArcAuthServiceTest.DisabledForEphemeralDataUsers

BUG= b/26402681
==========

[commit-bot: I haz the power, 2016-04-29 07:54:26]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-30 17:24:30]

Patchset 5 (id:??) landed as
https://crrev.com/79e934428a296d5b279c8da97aac3dfd1575af07
Cr-Commit-Position: refs/heads/master@{#390598}

[commit-bot: I haz the power, 2016-04-30 17:59:47]

Description was changed from

==========
Disabled ARC for ephemeral users.

And users which data is ephemeral (guests, demo, public etc.)

TEST: new added ArcAuthServiceTest.DisabledForEphemeralDataUsers

BUG= b/26402681
==========

to

==========
Disabled ARC for ephemeral users.

And users which data is ephemeral (guests, demo, public etc.)

TEST: new added ArcAuthServiceTest.DisabledForEphemeralDataUsers

BUG= b/26402681

Committed: https://crrev.com/79e934428a296d5b279c8da97aac3dfd1575af07
Cr-Commit-Position: refs/heads/master@{#390598}
==========