Issue 1922133002: Change 'const' -> 'constexpr' in cocoa/passwords.

Issue 1922133002: Change 'const' -> 'constexpr' in cocoa/passwords. (Closed)

Created:
4 years, 7 months ago by vasilii

Modified:
4 years, 7 months ago

Reviewers:
vabr (Chromium)

CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Change 'const' -> 'constexpr' in cocoa/passwords. Committed: https://crrev.com/2519ac28ec77e9c14bcfe273f938f8f5184985ab Cr-Commit-Position: refs/heads/master@{#389789}

Patch Set 1 #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -30 lines)			Patch
M	chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm	View	4 chunks	+9 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/passwords/auto_signin_view_controller.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/passwords/autosignin_prompt_view_controller_unittest.mm	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/passwords/credential_item_button.mm	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/passwords/passwords_bubble_utils.h	View	1 chunk	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/cocoa/passwords/pending_password_view_controller.mm	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/passwords/manage_passwords_view_utils.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/passwords/manage_passwords_view_utils.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 8 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922133002/1

4 years, 7 months ago (2016-04-26 15:18:59 UTC) #5

commit-bot: I haz the power

4 years, 7 months ago (2016-04-26 15:34:36 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/2519ac28ec77e9c14bcfe273f938f8f5184985ab
Cr-Commit-Position: refs/heads/master@{#389789}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages