Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1922113002: Revert of [qcms] Fix build_output_lut to return correct data for parametric curves (Closed)

Created:
4 years, 7 months ago by Marc Treib
Modified:
4 years, 7 months ago
Reviewers:
radu.velea, Noel Gordon
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [qcms] Fix build_output_lut to return correct data for parametric curves (patchset #13 id:240001 of https://codereview.chromium.org/1862053002/ ) Reason for revert: Breaks the build on Windows: https://build.chromium.org/p/chromium/builders/Win%20x64/builds/123 Original issue's description: > [qcms] Fix build_output_lut to return correct data for parametric curves > > build_output_lut() does not invert a parametric gamma curve when > computing the output curve data. The effect has not been visible > since Chrome only uses the output gamma values from the precache > table (which is inverted). > > Make build_output_lut() return inverted data for parametric gamma > curves. Add a test to write the inverted data, and the output of > LCMS function DefaultEvalParametricFn, to a file for comparison. > > For now the size of input and output gamma table for parametric > curves is hard-coded to 256; assert this in the test code. See > compute_curve_gamma_table_type_parametric for details. Future > implementations might return an arbitrary-sized table. > > BUG=600338 > > Committed: https://crrev.com/a89370950f514a3df77ed84240d4b8e3abbee801 > Cr-Commit-Position: refs/heads/master@{#389754} TBR=noel@chromium.org,radu.velea@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=600338 Committed: https://crrev.com/7b4905416ab871fe374f8879f5e13d4a50d0da6f Cr-Commit-Position: refs/heads/master@{#389762}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -506 lines) Patch
M third_party/qcms/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/qcms/README.chromium View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/qcms/qcms.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/qcms/src/tests/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M third_party/qcms/src/tests/qcms_test_main.c View 3 chunks +12 lines, -4 lines 0 comments Download
D third_party/qcms/src/tests/qcms_test_output_trc.c View 1 chunk +0 lines, -197 lines 0 comments Download
M third_party/qcms/src/tests/qcms_test_util.h View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/qcms/src/tests/qcms_test_util.c View 1 chunk +0 lines, -280 lines 0 comments Download
M third_party/qcms/src/transform_util.c View 2 chunks +2 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Marc Treib
Created Revert of [qcms] Fix build_output_lut to return correct data for parametric curves
4 years, 7 months ago (2016-04-26 13:06:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922113002/1
4 years, 7 months ago (2016-04-26 13:06:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-26 13:06:59 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7b4905416ab871fe374f8879f5e13d4a50d0da6f Cr-Commit-Position: refs/heads/master@{#389762}
4 years, 7 months ago (2016-04-26 13:08:04 UTC) #6
Noel Gordon
4 years, 7 months ago (2016-04-26 13:31:40 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698