Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issue 19221002: Use `file --dereference' instead of `readlink -f' + `file'. (Closed)

Created:
7 years, 5 months ago by Raphael Kubo da Costa (rakuco)
Modified:
7 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Use `file --dereference' instead of `readlink -f' + `file'. `readlink -f' is not standard and may not be present on all systems (such as some BSDs). Instead of the readlink+file combo, just ask file(1) to dereference the file it is given. R=mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211783

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M build/linux/python_arch.sh View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Raphael Kubo da Costa (rakuco)
7 years, 5 months ago (2013-07-15 16:10:18 UTC) #1
Mark Mentovai
You say you’re doing this because readlink is nonstandard, but so is the --dereference argument ...
7 years, 5 months ago (2013-07-15 16:30:20 UTC) #2
Raphael Kubo da Costa (rakuco)
On 2013/07/15 16:30:20, Mark Mentovai wrote: > You say you’re doing this because readlink is ...
7 years, 5 months ago (2013-07-15 18:41:23 UTC) #3
Mark Mentovai
Cross-compiling, right. LGTM.
7 years, 5 months ago (2013-07-15 19:11:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raphael.kubo.da.costa@intel.com/19221002/1
7 years, 5 months ago (2013-07-15 19:25:03 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=59456
7 years, 5 months ago (2013-07-15 21:12:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raphael.kubo.da.costa@intel.com/19221002/1
7 years, 5 months ago (2013-07-15 21:16:00 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=59521
7 years, 5 months ago (2013-07-15 22:51:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raphael.kubo.da.costa@intel.com/19221002/1
7 years, 5 months ago (2013-07-15 22:57:12 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=59565
7 years, 5 months ago (2013-07-15 23:59:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raphael.kubo.da.costa@intel.com/19221002/1
7 years, 5 months ago (2013-07-16 08:54:56 UTC) #11
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=60004
7 years, 5 months ago (2013-07-16 10:34:10 UTC) #12
Raphael Kubo da Costa (rakuco)
7 years, 5 months ago (2013-07-16 11:49:29 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 manually as r211783 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698