third_party/WebKit/Source/bindings/core/v8/custom/V8EventTargetCustom.cpp - Issue 1922093003: Add AddEventListenerOptions addEventListenerOptions interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8EventTargetCustom.cpp

Issue 1922093003: Add AddEventListenerOptions addEventListenerOptions interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/eventlisteneroptions/passive_query.html ('k') | third_party/WebKit/Source/core/core.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8EventTargetCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8EventTargetCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8EventTargetCustom.cpp

index f6db604f45d61588b4928add430550941f5b7b3d..4b20d29d37f0eefaf89a5594407c74b220254557 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8EventTargetCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8EventTargetCustom.cpp

@@ -95,7 +95,7 @@ void V8EventTarget::addEventListenerMethodCustom(const v8::FunctionCallbackInfo<

if (!type.prepare())

return;

EventListener* listener = V8EventListenerList::getEventListener(ScriptState::current(info.GetIsolate()), info[1], false, ListenerFindOrCreate);

- EventListenerOptionsOrBoolean options;

+ AddEventListenerOptionsOrBoolean options;

// TODO(dtapuska): This custom binding code can be eliminated once

// EventListenerOptions runtime enabled feature is removed.

// http://crbug.com/545163

@@ -105,7 +105,7 @@ void V8EventTarget::addEventListenerMethodCustom(const v8::FunctionCallbackInfo<

addEventListenerMethodEpilogueCustom(info, impl);

return;

}

- V8EventListenerOptionsOrBoolean::toImpl(info.GetIsolate(), info[2], options, UnionTypeConversionMode::NotNullable, exceptionState);

+ V8AddEventListenerOptionsOrBoolean::toImpl(info.GetIsolate(), info[2], options, UnionTypeConversionMode::NotNullable, exceptionState);

if (exceptionState.throwIfNeeded())

return;

addEventListenerMethodPrologueCustom(info, impl);