third_party/WebKit/Source/core/events/EventTarget.h - Issue 1922093003: Add AddEventListenerOptions addEventListenerOptions interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/events/EventTarget.h

Issue 1922093003: Add AddEventListenerOptions addEventListenerOptions interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/events/EventListenerMap.cpp ('K') | « third_party/WebKit/Source/core/events/EventListenerOptions.idl ('k') | third_party/WebKit/Source/core/events/EventTarget.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/events/EventTarget.h

diff --git a/third_party/WebKit/Source/core/events/EventTarget.h b/third_party/WebKit/Source/core/events/EventTarget.h

index 827faa27bc756f05a97cfcc0991302a38498cf99..6e41691a6cc15132f9c3787fdb1e0f2586f2ff21 100644

--- a/third_party/WebKit/Source/core/events/EventTarget.h

+++ b/third_party/WebKit/Source/core/events/EventTarget.h

@@ -114,8 +114,8 @@ public:

virtual MessagePort* toMessagePort();

bool addEventListener(const AtomicString& eventType, EventListener*, bool useCapture = false);

- bool addEventListener(const AtomicString& eventType, EventListener*, const EventListenerOptionsOrBoolean&);

- bool addEventListener(const AtomicString& eventType, EventListener*, EventListenerOptions&);

+ bool addEventListener(const AtomicString& eventType, EventListener*, const AddEventListenerOptionsOrBoolean&);

+ bool addEventListener(const AtomicString& eventType, EventListener*, AddEventListenerOptions&);

bool removeEventListener(const AtomicString& eventType, EventListener*, bool useCapture = false);

bool removeEventListener(const AtomicString& eventType, EventListener*, const EventListenerOptionsOrBoolean&);

@@ -151,8 +151,9 @@ public:

protected:

EventTarget();

- virtual bool addEventListenerInternal(const AtomicString& eventType, EventListener*, const EventListenerOptions&);

+ virtual bool addEventListenerInternal(const AtomicString& eventType, EventListener*, const AddEventListenerOptions&);

virtual bool removeEventListenerInternal(const AtomicString& eventType, EventListener*, const EventListenerOptions&);

+ virtual void removedEventListener(const AtomicString& eventType, const RegisteredEventListener&);

virtual DispatchEventResult dispatchEventInternal(Event*);

// Subclasses should likely not override these themselves; instead, they should subclass EventTargetWithInlineData.