Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1922093002:
[MediaFling] Fix timestamp issue in remote media playback (Closed)
|
Created:
4 years, 8 months ago by Zhiqiang Zhang (Slow) Modified:
4 years, 8 months ago Reviewers:
whywhat CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[MediaFling] Fix timestamp issue in remote media playback
This CL fixes a bug caused by the MediaItemStatus timestamp
inconsistency between the GMS core CastMediaRouteProvider and
PositionExtrapolator. The timestamp from the GMS core is overridden by
the elapsedRealtime.
BUG=606722
TEST=manual test on multiple devices
Committed: https://crrev.com/d4b8069a230bc157f020ffaab138887a2bd63dd4
Cr-Commit-Position: refs/heads/master@{#389772}
Patch Set 1 #
Total comments: 1
Patch Set 2 : addressed comments #Messages
Total messages: 19 (10 generated)
The CQ bit was checked by zqzhang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922093002/1
zqzhang@chromium.org changed reviewers: + avayvod@chromium.org
lgtm (I think we need to perform some extensive testing of this change) https://codereview.chromium.org/1922093002/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/media/remote/DefaultMediaRouteController.java (right): https://codereview.chromium.org/1922093002/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/remote/DefaultMediaRouteController.java:669: // TODO(zqzhang): The GMS core currently uses SystemClock.uptimeMillis() as nit: you can mention b/28378525 here.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [MediaFling] Fix timestamp issue in remote media playback This CL fixes a bug caused by the MediaItemStatus timestamp inconsistency between the GMS core CastMediaRouteProvider and PositionExtrapolator. The timestamp from the GMS core is overridden by the elapsedRealtime. BUG=606722 ========== to ========== [MediaFling] Fix timestamp issue in remote media playback This CL fixes a bug caused by the MediaItemStatus timestamp inconsistency between the GMS core CastMediaRouteProvider and PositionExtrapolator. The timestamp from the GMS core is overridden by the elapsedRealtime. BUG=606722 TEST=manual test on multiple devices ==========
The CQ bit was checked by zqzhang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922093002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by avayvod@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from avayvod@chromium.org Link to the patchset: https://codereview.chromium.org/1922093002/#ps20001 (title: "addressed comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922093002/20001
Message was sent while issue was closed.
Description was changed from ========== [MediaFling] Fix timestamp issue in remote media playback This CL fixes a bug caused by the MediaItemStatus timestamp inconsistency between the GMS core CastMediaRouteProvider and PositionExtrapolator. The timestamp from the GMS core is overridden by the elapsedRealtime. BUG=606722 TEST=manual test on multiple devices ========== to ========== [MediaFling] Fix timestamp issue in remote media playback This CL fixes a bug caused by the MediaItemStatus timestamp inconsistency between the GMS core CastMediaRouteProvider and PositionExtrapolator. The timestamp from the GMS core is overridden by the elapsedRealtime. BUG=606722 TEST=manual test on multiple devices ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [MediaFling] Fix timestamp issue in remote media playback This CL fixes a bug caused by the MediaItemStatus timestamp inconsistency between the GMS core CastMediaRouteProvider and PositionExtrapolator. The timestamp from the GMS core is overridden by the elapsedRealtime. BUG=606722 TEST=manual test on multiple devices ========== to ========== [MediaFling] Fix timestamp issue in remote media playback This CL fixes a bug caused by the MediaItemStatus timestamp inconsistency between the GMS core CastMediaRouteProvider and PositionExtrapolator. The timestamp from the GMS core is overridden by the elapsedRealtime. BUG=606722 TEST=manual test on multiple devices Committed: https://crrev.com/d4b8069a230bc157f020ffaab138887a2bd63dd4 Cr-Commit-Position: refs/heads/master@{#389772} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/d4b8069a230bc157f020ffaab138887a2bd63dd4 Cr-Commit-Position: refs/heads/master@{#389772} |
