components/ntp_snippets.gypi - Issue 1922083004: Allow fetching personalized snippets from ChromeReader.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets.gypi

Issue 1922083004: Allow fetching personalized snippets from ChromeReader. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: After code review #5 Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/snippets_internals_message_handler.cc ('k') | components/ntp_snippets/BUILD.gn » ('j') | components/ntp_snippets/ntp_snippets_fetcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets.gypi

diff --git a/components/ntp_snippets.gypi b/components/ntp_snippets.gypi

index 3b1f7ba48716b280812d16995b507b1510c64e2f..d85a2574779a4c0d195e1a6b9917e6cedd88333c 100644

--- a/components/ntp_snippets.gypi

+++ b/components/ntp_snippets.gypi

@@ -22,11 +22,14 @@

'prefs/prefs.gyp:prefs',

'signin_core_browser',

'suggestions',

+ 'variations',

'sources': [

'ntp_snippets/inner_iterator.h',

'ntp_snippets/ntp_snippet.cc',

'ntp_snippets/ntp_snippet.h',

+ 'ntp_snippets_constants.cc',

+ 'ntp_snippets_constants.h',

Marc Treib 2016/05/10 08:42:19 These are missing "ntp_snippets/", hence the build

jkrcal 2016/05/10 09:10:07 Thanks! (I've realized in the meantime...)

'ntp_snippets/ntp_snippets_fetcher.cc',

'ntp_snippets/ntp_snippets_fetcher.h',

'ntp_snippets/ntp_snippets_scheduler.h',