Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: components/ntp_snippets/ntp_snippet.cc

Issue 1922083004: Allow fetching personalized snippets from ChromeReader. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: After code review #2 Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/ntp_snippet.cc
diff --git a/components/ntp_snippets/ntp_snippet.cc b/components/ntp_snippets/ntp_snippet.cc
index dcac6d27908fa1b2f51124e3502818f6668543ed..69fd81acc397abaca2ec84c5c93d2c41a74fd3f8 100644
--- a/components/ntp_snippets/ntp_snippet.cc
+++ b/components/ntp_snippets/ntp_snippet.cc
@@ -9,6 +9,9 @@
namespace {
+const char kScore[] = "score";
+const char kContentInfo[] = "contentInfo";
+
const char kUrl[] = "url";
const char kSiteTitle[] = "site_title";
const char kTitle[] = "title";
@@ -24,7 +27,9 @@ const char kAmpUrl[] = "ampUrl";
namespace ntp_snippets {
-NTPSnippet::NTPSnippet(const GURL& url) : url_(url) {
+NTPSnippet::NTPSnippet(const GURL& url) :
+ url_(url),
+ score_(0) {
DCHECK(url_.is_valid());
}
@@ -33,9 +38,13 @@ NTPSnippet::~NTPSnippet() {}
// static
std::unique_ptr<NTPSnippet> NTPSnippet::CreateFromDictionary(
const base::DictionaryValue& dict) {
+ const base::DictionaryValue* content = nullptr;
+ if (!dict.GetDictionary(kContentInfo, &content))
+ return nullptr;
+
// Need at least the url.
std::string url_str;
- if (!dict.GetString("url", &url_str))
+ if (!content->GetString("url", &url_str))
return nullptr;
GURL url(url_str);
if (!url.is_valid())
@@ -44,30 +53,30 @@ std::unique_ptr<NTPSnippet> NTPSnippet::CreateFromDictionary(
std::unique_ptr<NTPSnippet> snippet(new NTPSnippet(url));
std::string site_title;
- if (dict.GetString(kSiteTitle, &site_title))
+ if (content->GetString(kSiteTitle, &site_title))
snippet->set_site_title(site_title);
std::string title;
- if (dict.GetString(kTitle, &title))
+ if (content->GetString(kTitle, &title))
snippet->set_title(title);
std::string favicon_url;
- if (dict.GetString(kFaviconUrl, &favicon_url))
+ if (content->GetString(kFaviconUrl, &favicon_url))
snippet->set_favicon_url(GURL(favicon_url));
std::string salient_image_url;
- if (dict.GetString(kSalientImageUrl, &salient_image_url))
+ if (content->GetString(kSalientImageUrl, &salient_image_url))
snippet->set_salient_image_url(GURL(salient_image_url));
std::string snippet_str;
- if (dict.GetString(kSnippet, &snippet_str))
+ if (content->GetString(kSnippet, &snippet_str))
snippet->set_snippet(snippet_str);
// The creation and expiry timestamps are uint64s which are stored as strings.
std::string creation_timestamp_str;
- if (dict.GetString(kPublishDate, &creation_timestamp_str))
+ if (content->GetString(kPublishDate, &creation_timestamp_str))
snippet->set_publish_date(TimeFromJsonString(creation_timestamp_str));
std::string expiry_timestamp_str;
- if (dict.GetString(kExpiryDate, &expiry_timestamp_str))
+ if (content->GetString(kExpiryDate, &expiry_timestamp_str))
snippet->set_expiry_date(TimeFromJsonString(expiry_timestamp_str));
const base::ListValue* corpus_infos_list = nullptr;
- if (dict.GetList(kSourceCorpusInfo, &corpus_infos_list)) {
+ if (content->GetList(kSourceCorpusInfo, &corpus_infos_list)) {
for (base::Value* value : *corpus_infos_list) {
const base::DictionaryValue* dict_value = nullptr;
if (value->GetAsDictionary(&dict_value)) {
@@ -80,35 +89,45 @@ std::unique_ptr<NTPSnippet> NTPSnippet::CreateFromDictionary(
}
}
+ double score;
+ if (dict.GetDouble(kScore, &score))
+ snippet->set_score(score);
+
return snippet;
}
std::unique_ptr<base::DictionaryValue> NTPSnippet::ToDictionary() const {
- std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue);
+ std::unique_ptr<base::DictionaryValue> content(new base::DictionaryValue);
- dict->SetString(kUrl, url_.spec());
+ content->SetString(kUrl, url_.spec());
if (!site_title_.empty())
- dict->SetString(kSiteTitle, site_title_);
+ content->SetString(kSiteTitle, site_title_);
if (!title_.empty())
- dict->SetString(kTitle, title_);
+ content->SetString(kTitle, title_);
if (favicon_url_.is_valid())
- dict->SetString(kFaviconUrl, favicon_url_.spec());
+ content->SetString(kFaviconUrl, favicon_url_.spec());
if (salient_image_url_.is_valid())
- dict->SetString(kSalientImageUrl, salient_image_url_.spec());
+ content->SetString(kSalientImageUrl, salient_image_url_.spec());
if (!snippet_.empty())
- dict->SetString(kSnippet, snippet_);
+ content->SetString(kSnippet, snippet_);
if (!publish_date_.is_null())
- dict->SetString(kPublishDate, TimeToJsonString(publish_date_));
+ content->SetString(kPublishDate, TimeToJsonString(publish_date_));
if (!expiry_date_.is_null())
- dict->SetString(kExpiryDate, TimeToJsonString(expiry_date_));
+ content->SetString(kExpiryDate, TimeToJsonString(expiry_date_));
if (amp_url_.is_valid()) {
std::unique_ptr<base::ListValue> corpus_infos_list(new base::ListValue);
std::unique_ptr<base::DictionaryValue> corpus_info_dict(
new base::DictionaryValue);
corpus_info_dict->SetString(kAmpUrl, amp_url_.spec());
corpus_infos_list->Set(0, std::move(corpus_info_dict));
- dict->Set(kSourceCorpusInfo, std::move(corpus_infos_list));
+ content->Set(kSourceCorpusInfo, std::move(corpus_infos_list));
}
+
+ std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue);
+ dict->Set(kContentInfo, std::move(content));
+
+ dict->SetDouble(kScore, score_);
+
return dict;
}

Powered by Google App Engine
This is Rietveld 408576698