components/ntp_snippets/BUILD.gn - Issue 1922083004: Allow fetching personalized snippets from ChromeReader.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/BUILD.gn

Issue 1922083004: Allow fetching personalized snippets from ChromeReader. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: After code review #2 Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/ntp_snippets/BUILD.gn

diff --git a/components/ntp_snippets/BUILD.gn b/components/ntp_snippets/BUILD.gn

index 382aa911a2294f816816cddd0ec43af8c444a5dd..518b0ab4d6fbf35bb58fd35b8d6f4aa69d0ce024 100644

--- a/components/ntp_snippets/BUILD.gn

+++ b/components/ntp_snippets/BUILD.gn

@@ -8,6 +8,8 @@ source_set("ntp_snippets") {

"inner_iterator.h",

"ntp_snippet.cc",

"ntp_snippet.h",

+ "ntp_snippets_constants.cc",

+ "ntp_snippets_constants.h",

"ntp_snippets_fetcher.cc",

"ntp_snippets_fetcher.h",

"ntp_snippets_scheduler.h",

@@ -32,6 +34,7 @@ source_set("ntp_snippets") {

deps = [

"//components/metrics",

+ "//components/variations",

]

}

« no previous file with comments | « components/ntp_snippets.gypi ('k') | components/ntp_snippets/DEPS » ('j') | components/ntp_snippets/ntp_snippets_fetcher.cc » ('J')