Allow fetching personalized snippets from ChromeReader.

components/ntp_snippets/ntp_snippets_fetcher_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/ntp_snippets_fetcher.h"
 
 #include "base/json/json_reader.h"
 #include "base/memory/ptr_util.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "base/strings/stringprintf.h"
 #include "base/test/histogram_tester.h"
 #include "base/thread_task_runner_handle.h"
 #include "base/values.h"
 #include "components/ntp_snippets/ntp_snippet.h"
+#include "components/signin/core/browser/account_tracker_service.h"
+#include "components/signin/core/browser/fake_profile_oauth2_token_service.h"
+#include "components/signin/core/browser/fake_signin_manager.h"
+#include "components/signin/core/browser/test_signin_client.h"
 #include "google_apis/google_api_keys.h"
 #include "net/url_request/test_url_fetcher_factory.h"
 #include "net/url_request/url_request_test_util.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace ntp_snippets {
 namespace {
 
 using testing::ElementsAre;
@@ skipping 40 matching lines @@
   std::unique_ptr<base::Value> value = json_reader.ReadToValue(json);
   if (value)
     success_callback.Run(std::move(value));
   else
     error_callback.Run(json_reader.GetErrorMessage());
 }
 
 class NTPSnippetsFetcherTest : public testing::Test {
  public:
   NTPSnippetsFetcherTest()
-      : snippets_fetcher_(scoped_refptr<net::TestURLRequestContextGetter>(
+      : signin_client_(new TestSigninClient(nullptr)),
+        account_tracker_(new AccountTrackerService()),
+        snippets_fetcher_(new FakeSigninManagerBase(signin_client_.get(),
+                                                    account_tracker_.get()),
+                          new FakeProfileOAuth2TokenService(),
+                          scoped_refptr<net::TestURLRequestContextGetter>(
                               new net::TestURLRequestContextGetter(
                                   base::ThreadTaskRunnerHandle::Get())),
                           base::Bind(&ParseJson),
                           /*is_stable_channel=*/true),
         test_url_(base::StringPrintf(kTestContentSnippetsServerFormat,
                                      google_apis::GetAPIKey().c_str())) {
     snippets_fetcher_.SetCallback(
         base::Bind(&MockSnippetsAvailableCallback::WrappedRun,
                    base::Unretained(&mock_callback_)));
     test_hosts_.insert("www.somehost.com");
@@ skipping 20 matching lines @@
                        net::URLRequestStatus::Status status) {
     InitFakeURLFetcherFactory();
     fake_url_fetcher_factory_->SetFakeResponse(test_url_, response_data,
                                                response_code, status);
   }
 
  private:
   FailingFakeURLFetcherFactory failing_url_fetcher_factory_;
   // Initialized lazily in SetFakeResponse().
   std::unique_ptr<net::FakeURLFetcherFactory> fake_url_fetcher_factory_;
+  std::unique_ptr<TestSigninClient> signin_client_;
+  std::unique_ptr<AccountTrackerService> account_tracker_;
   // Needed to use ThreadTaskRunnerHandle.
   base::MessageLoop message_loop_;
   NTPSnippetsFetcher snippets_fetcher_;
   MockSnippetsAvailableCallback mock_callback_;
   const GURL test_url_;
   std::set<std::string> test_hosts_;
   base::HistogramTester histogram_tester_;
 
   DISALLOW_COPY_AND_ASSIGN(NTPSnippetsFetcherTest);
 };
@@ skipping 16 matching lines @@
       "      \"corpusId\" : \"http://localhost/foobar\","
       "      \"publisherData\": { \"sourceName\" : \"Foo News\" }"
       "    }]"
       "  }"
       "}]}";
   SetFakeResponse(/*data=*/kJsonStr, net::HTTP_OK,
                   net::URLRequestStatus::SUCCESS);
   EXPECT_CALL(mock_callback(), Run(/*snippets=*/SizeIs(1),
                                    /*status_message=*/std::string()))
       .Times(1);
-  snippets_fetcher().FetchSnippetsFromHosts(test_hosts(), /*count=*/1);
+  snippets_fetcher().FetchSnippetsFromHosts(test_hosts(),
+                                            /*language_code=*/"en-US",
+                                            /*count=*/1);
   RunUntilIdle();
   EXPECT_THAT(snippets_fetcher().last_json(), Eq(kJsonStr));
   EXPECT_THAT(histogram_tester().GetAllSamples(
                   "NewTabPage.Snippets.FetchHttpResponseOrErrorCode"),
               ElementsAre(base::Bucket(/*min=*/200, /*count=*/1)));
 }
 
 TEST_F(NTPSnippetsFetcherTest, ShouldFetchSuccessfullyEmptyList) {
   const std::string kJsonStr = "{\"recos\": []}";
   SetFakeResponse(/*data=*/kJsonStr, net::HTTP_OK,
                   net::URLRequestStatus::SUCCESS);
   EXPECT_CALL(mock_callback(), Run(/*snippets=*/IsEmpty(),
                                    /*status_message=*/std::string()))
       .Times(1);
-  snippets_fetcher().FetchSnippetsFromHosts(test_hosts(), /*count=*/1);
+  snippets_fetcher().FetchSnippetsFromHosts(test_hosts(),
+                                            /*language_code=*/"en-US",
+                                            /*count=*/1);
   RunUntilIdle();
   EXPECT_THAT(snippets_fetcher().last_json(), Eq(kJsonStr));
   EXPECT_THAT(histogram_tester().GetAllSamples(
                   "NewTabPage.Snippets.FetchHttpResponseOrErrorCode"),
               ElementsAre(base::Bucket(/*min=*/200, /*count=*/1)));
 }
 
 TEST_F(NTPSnippetsFetcherTest, ShouldReportEmptyHostsError) {
   EXPECT_CALL(mock_callback(),
               Run(/*snippets=*/IsEmpty(),
                   /*status_message=*/"Cannot fetch for empty hosts list."))
       .Times(1);
   snippets_fetcher().FetchSnippetsFromHosts(/*hosts=*/std::set<std::string>(),
+                                            /*language_code=*/"en-US",
                                             /*count=*/1);
   RunUntilIdle();
   EXPECT_THAT(snippets_fetcher().last_json(), IsEmpty());
   EXPECT_THAT(histogram_tester().GetAllSamples(
                   "NewTabPage.Snippets.FetchHttpResponseOrErrorCode"),
               IsEmpty());
 }
 
 TEST_F(NTPSnippetsFetcherTest, ShouldRestrictToHosts) {
   net::TestURLFetcherFactory test_url_fetcher_factory;
-  snippets_fetcher().FetchSnippetsFromHosts(test_hosts(), /*count=*/17);
+  snippets_fetcher().FetchSnippetsFromHosts(test_hosts(),
+                                            /*language_code=*/"en-US",
+                                            /*count=*/17);
   net::TestURLFetcher* fetcher = test_url_fetcher_factory.GetFetcherByID(0);
   ASSERT_THAT(fetcher, NotNull());
   std::unique_ptr<base::Value> value =
       base::JSONReader::Read(fetcher->upload_data());
   ASSERT_TRUE(value);
   const base::DictionaryValue* dict;
   ASSERT_TRUE(value->GetAsDictionary(&dict));
   const base::DictionaryValue* local_scoring_params;
   ASSERT_TRUE(dict->GetDictionary("advanced_options.local_scoring_params",
                                   &local_scoring_params));
   const base::DictionaryValue* content_selectors;
   ASSERT_TRUE(local_scoring_params->GetDictionary("content_selectors",
                                                   &content_selectors));
   std::string content_selector_value;
   EXPECT_TRUE(content_selectors->GetString("value", &content_selector_value));
   EXPECT_THAT(content_selector_value, Eq("www.somehost.com"));
 }
 
 TEST_F(NTPSnippetsFetcherTest, ShouldReportUrlStatusError) {
   SetFakeResponse(/*data=*/std::string(), net::HTTP_NOT_FOUND,
                   net::URLRequestStatus::FAILED);
   EXPECT_CALL(mock_callback(),
               Run(/*snippets=*/IsEmpty(),
                   /*status_message=*/"URLRequestStatus error -2"))
       .Times(1);
-  snippets_fetcher().FetchSnippetsFromHosts(test_hosts(), /*count=*/1);
+  snippets_fetcher().FetchSnippetsFromHosts(test_hosts(),
+                                            /*language_code=*/"en-US",
+                                            /*count=*/1);
   RunUntilIdle();
   EXPECT_THAT(snippets_fetcher().last_json(), IsEmpty());
   EXPECT_THAT(histogram_tester().GetAllSamples(
                   "NewTabPage.Snippets.FetchHttpResponseOrErrorCode"),
               ElementsAre(base::Bucket(/*min=*/-2, /*count=*/1)));
 }
 
 TEST_F(NTPSnippetsFetcherTest, ShouldReportHttpError) {
   SetFakeResponse(/*data=*/std::string(), net::HTTP_NOT_FOUND,
                   net::URLRequestStatus::SUCCESS);
   EXPECT_CALL(mock_callback(), Run(/*snippets=*/IsEmpty(),
                                    /*status_message=*/"HTTP error 404"))
       .Times(1);
-  snippets_fetcher().FetchSnippetsFromHosts(test_hosts(), /*count=*/1);
+  snippets_fetcher().FetchSnippetsFromHosts(test_hosts(),
+                                            /*language_code=*/"en-US",
+                                            /*count=*/1);
   RunUntilIdle();
   EXPECT_THAT(snippets_fetcher().last_json(), IsEmpty());
   EXPECT_THAT(histogram_tester().GetAllSamples(
                   "NewTabPage.Snippets.FetchHttpResponseOrErrorCode"),
               ElementsAre(base::Bucket(/*min=*/404, /*count=*/1)));
 }
 
 TEST_F(NTPSnippetsFetcherTest, ShouldReportJsonError) {
   const std::string kInvalidJsonStr = "{ \"recos\": []";
   SetFakeResponse(/*data=*/kInvalidJsonStr, net::HTTP_OK,
                   net::URLRequestStatus::SUCCESS);
   EXPECT_CALL(
       mock_callback(),
       Run(/*snippets=*/IsEmpty(),
           /*status_message=*/StartsWith("Received invalid JSON (error ")))
       .Times(1);
-  snippets_fetcher().FetchSnippetsFromHosts(test_hosts(), /*count=*/1);
+  snippets_fetcher().FetchSnippetsFromHosts(test_hosts(),
+                                            /*language_code=*/"en-US",
+                                            /*count=*/1);
   RunUntilIdle();
   EXPECT_THAT(snippets_fetcher().last_json(), Eq(kInvalidJsonStr));
   EXPECT_THAT(histogram_tester().GetAllSamples(
                   "NewTabPage.Snippets.FetchHttpResponseOrErrorCode"),
               ElementsAre(base::Bucket(/*min=*/200, /*count=*/1)));
 }
 
 TEST_F(NTPSnippetsFetcherTest, ShouldReportJsonErrorForEmptyResponse) {
   SetFakeResponse(/*data=*/std::string(), net::HTTP_OK,
                   net::URLRequestStatus::SUCCESS);
   EXPECT_CALL(
       mock_callback(),
       Run(/*snippets=*/IsEmpty(),
           /*status_message=*/StartsWith("Received invalid JSON (error ")))
       .Times(1);
-  snippets_fetcher().FetchSnippetsFromHosts(test_hosts(), /*count=*/1);
+  snippets_fetcher().FetchSnippetsFromHosts(test_hosts(),
+                                            /*language_code=*/"en-US",
+                                            /*count=*/1);
   RunUntilIdle();
   EXPECT_THAT(snippets_fetcher().last_json(), std::string());
   EXPECT_THAT(histogram_tester().GetAllSamples(
                   "NewTabPage.Snippets.FetchHttpResponseOrErrorCode"),
               ElementsAre(base::Bucket(/*min=*/200, /*count=*/1)));
 }
 
 TEST_F(NTPSnippetsFetcherTest, ShouldReportInvalidListError) {
   const std::string kJsonStr =
       "{\"recos\": [{ \"contentInfo\": { \"foo\" : \"bar\" }}]}";
   SetFakeResponse(/*data=*/kJsonStr, net::HTTP_OK,
                   net::URLRequestStatus::SUCCESS);
   EXPECT_CALL(mock_callback(), Run(/*snippets=*/IsEmpty(),
                                    /*status_message=*/"Invalid / empty list."))
       .Times(1);
-  snippets_fetcher().FetchSnippetsFromHosts(test_hosts(), /*count=*/1);
+  snippets_fetcher().FetchSnippetsFromHosts(test_hosts(),
+                                            /*language_code=*/"en-US",
+                                            /*count=*/1);
   RunUntilIdle();
   EXPECT_THAT(snippets_fetcher().last_json(), Eq(kJsonStr));
   EXPECT_THAT(histogram_tester().GetAllSamples(
                   "NewTabPage.Snippets.FetchHttpResponseOrErrorCode"),
               ElementsAre(base::Bucket(/*min=*/200, /*count=*/1)));
 }
 
 // This test actually verifies that the test setup itself is sane, to prevent
 // hard-to-reproduce test failures.
 TEST_F(NTPSnippetsFetcherTest, ShouldReportHttpErrorForMissingBakedResponse) {
   InitFakeURLFetcherFactory();
   EXPECT_CALL(mock_callback(), Run(/*snippets=*/IsEmpty(),
                                    /*status_message=*/Not(IsEmpty())))
       .Times(1);
-  snippets_fetcher().FetchSnippetsFromHosts(test_hosts(), /*count=*/1);
+  snippets_fetcher().FetchSnippetsFromHosts(test_hosts(),
+                                            /*language_code=*/"en-US",
+                                            /*count=*/1);
   RunUntilIdle();
 }
 
 TEST_F(NTPSnippetsFetcherTest, ShouldCancelOngoingFetch) {
   const std::string kJsonStr = "{ \"recos\": [] }";
   SetFakeResponse(/*data=*/kJsonStr, net::HTTP_OK,
                   net::URLRequestStatus::SUCCESS);
   EXPECT_CALL(mock_callback(), Run(/*snippets=*/IsEmpty(),
                                    /*status_message=*/std::string()))
       .Times(1);
-  snippets_fetcher().FetchSnippetsFromHosts(test_hosts(), /*count=*/1);
+  snippets_fetcher().FetchSnippetsFromHosts(test_hosts(),
+                                            /*language_code=*/"en-US",
+                                            /*count=*/1);
   // Second call to FetchSnippetsFromHosts() overrides/cancels the previous.
   // Callback is expected to be called once.
-  snippets_fetcher().FetchSnippetsFromHosts(test_hosts(), /*count=*/1);
+  snippets_fetcher().FetchSnippetsFromHosts(test_hosts(),
+                                            /*language_code=*/"en-US",
+                                            /*count=*/1);
   RunUntilIdle();
   EXPECT_THAT(histogram_tester().GetAllSamples(
                   "NewTabPage.Snippets.FetchHttpResponseOrErrorCode"),
               ElementsAre(base::Bucket(/*min=*/200, /*count=*/1)));
 }
 
 }  // namespace
 }  // namespace ntp_snippets