Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1922073003:
Add comments and sanity checks to parsing of ICC headers (Closed)
DescriptionAdd comments and sanity checks to parsing of ICC headers
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1922073003
Committed: https://skia.googlesource.com/skia/+/92bd2e8f32a6e1d68ecc9f12a043518087c283d2
Patch Set 1 : #
Total comments: 2
Dependent Patchsets: Messages
Total messages: 24 (13 generated)
Description was changed from ========== Add comments and sanity checks to parsing of ICC headers BUG=skia: ========== to ========== Add comments and sanity checks to parsing of ICC headers BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Patchset #1 (id:1) has been deleted
msarett@google.com changed reviewers: + scroggo@google.com
The CQ bit was checked by msarett@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922073003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922073003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...) Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...) Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
The CQ bit was checked by msarett@google.com to run a CQ dry run
Patchset #1 (id:20001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922073003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922073003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
The CQ bit was checked by msarett@google.com to run a CQ dry run
Patchset #1 (id:40001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922073003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922073003/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/1922073003/diff/60001/src/core/SkColorSpace.cpp File src/core/SkColorSpace.cpp (right): https://codereview.chromium.org/1922073003/diff/60001/src/core/SkColorSpace.c... src/core/SkColorSpace.cpp:299: "Illuminant must be D50"); Was this intended to be more flexible in future versions?
https://codereview.chromium.org/1922073003/diff/60001/src/core/SkColorSpace.cpp File src/core/SkColorSpace.cpp (right): https://codereview.chromium.org/1922073003/diff/60001/src/core/SkColorSpace.c... src/core/SkColorSpace.cpp:299: "Illuminant must be D50"); On 2016/04/27 11:55:44, scroggo wrote: > Was this intended to be more flexible in future versions? I don't know... It doesn't look like they are headed that way though. In v4, they also started requiring that the white point tag matches the D50 illuminant. All the sources I've seen say "ICC always means D50".
The CQ bit was checked by msarett@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922073003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922073003/60001
Message was sent while issue was closed.
Description was changed from ========== Add comments and sanity checks to parsing of ICC headers BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Add comments and sanity checks to parsing of ICC headers BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/92bd2e8f32a6e1d68ecc9f12a043518087c283d2 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:60001) as https://skia.googlesource.com/skia/+/92bd2e8f32a6e1d68ecc9f12a043518087c283d2 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
